[jboss-jira] [JBoss JIRA] Closed: (JASSIST-89) The implementation of isInheritable() in CtNewClass is wrong.

[Shigeru Chiba (JIRA)]

     [ https://jira.jboss.org/jira/browse/JASSIST-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shigeru Chiba closed JASSIST-89.
--------------------------------



> The implementation of isInheritable() in CtNewClass is wrong.
> -------------------------------------------------------------
>
>                 Key: JASSIST-89
>                 URL: https://jira.jboss.org/jira/browse/JASSIST-89
>             Project: Javassist
>          Issue Type: Bug
>    Affects Versions: 3.11.0.GA
>            Reporter: Shigeru Chiba
>            Assignee: Shigeru Chiba
>             Fix For: 3.12.0.GA
>
>
> In CtNewClass,
> private boolean isInheritable(int mod, CtClass superclazz) {
>         if (Modifier.isPrivate(mod))
>             return false;
>         if (Modifier.isPackage(mod)) {
>             String pname = getPackageName();
>             String pname2 = superclazz.getPackageName();
>             if (pname == null)
>                 return pname2 == null;
>             else
>                 pname.equals(pname2);        // <==== should return pname.equals(pname2)
>         }
>         return true;
>     }
> Originally reported by Michihiro Horie

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira