[jboss-jira] [JBoss JIRA] Commented: (JBAS-6888) aoptest.sar unable to deploy on IBM JDK - some aop tests failing

[Kabir Khan (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12472107#action_12472107 ] 

Kabir Khan commented on JBAS-6888:
----------------------------------

Assuming that clazz.getDeclaringClass() is called only in the generated advisor constructor, in GeneratedAdvisorInstrumentor.createAdvisorCtors(), maybe the string should be something like the following

   protected void createAdvisorCtors(CtClass clazz)throws CannotCompileException, NotFoundException
   {
      String initBody =
         "{" +
         "   java.lang.String domainName = org.jboss.aop.Domain.getDomainName(" + clazz.getName() + ".class, $2);" + 
         "   " + DOMAIN + "= new org.jboss.aop.GeneratedAdvisorDomain($1, domainName, " + clazz.getName() + ".class, $2); " +
         "   ((org.jboss.aop.Domain)" + DOMAIN + ").setInheritsBindings(true); " +
         "   super.initialise(" + clazz.getName() + ".class, " + DOMAIN + ");" +
         "}";
}

instead of
   protected void createAdvisorCtors(CtClass clazz)throws CannotCompileException, NotFoundException
   {
      String initBody =
         "{" +
         "   java.lang.String domainName = org.jboss.aop.Domain.getDomainName(" + DECLARING_CLASS + ", $2);" + 
         "   " + DOMAIN + "= new org.jboss.aop.GeneratedAdvisorDomain($1, domainName, " + DECLARING_CLASS + ", $2); " +
         "   ((org.jboss.aop.Domain)" + DOMAIN + ").setInheritsBindings(true); " +
         "   super.initialise(" + DECLARING_CLASS + ", " + DOMAIN + ");" +
         "}";
   }

> aoptest.sar unable to deploy on IBM JDK - some aop tests failing
> ----------------------------------------------------------------
>
>                 Key: JBAS-6888
>                 URL: https://jira.jboss.org/jira/browse/JBAS-6888
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Test Suite
>    Affects Versions: JBossAS-5.1.0.CR1
>         Environment: IBM JDK 1.5 or 1.6
>            Reporter: Martin Malina
>            Assignee: Flavia Rainone
>         Attachments: server.log
>
>
> Several tests in the org.jboss.test.aop.test package fail due to aoptest.sar not being deployed properly.
> The failing tests include:
> org.jboss.test.aop.test.AOPUnitTestCase
> org.jboss.test.aop.test.JMXUnitTestCase
> org.jboss.test.aop.test.ObservableUnitTestCase
> org.jboss.test.aop.test.RemotingUnitTestCase
> org.jboss.test.aop.test.SecurityUnitTestCase
> org.jboss.test.aop.test.TxLockUnitTestCase
> org.jboss.test.aop.test.TxUnitTestCase
> org.jboss.test.aop.test.VersionedObjectUnitTestCase
> This is the junit report:
> Failed to deploy: file:/qa/services/hudson/hudson_workspace/workspace/eap5-as-rhel4-x86-ibm/src/jboss-5.1.0.CR1-src/testsuite/output/lib/aoptest.sar
> org.jboss.deployment.DeploymentException: Failed to deploy: file:/qa/services/hudson/hudson_workspace/workspace/eap5-as-rhel4-x86-ibm/src/jboss-5.1.0.CR1-src/testsuite/output/lib/aoptest.sar
> 	at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:838)
> 	at org.jboss.deployment.MainDeployer.redeploy(MainDeployer.java:604)
> 	at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
> 	at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
> 	at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
> 	at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
> 	at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
> 	at org.jboss.jmx.connector.invoker.InvokerAdaptorService.invoke(InvokerAdaptorService.java:263)
> 	at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
> 	at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
> 	at org.jboss.mx.interceptor.AbstractInterceptor.invoke(AbstractInterceptor.java:138)
> 	at org.jboss.mx.server.Invocation.invoke(Invocation.java:90)
> 	at org.jboss.mx.interceptor.ModelMBeanOperationInterceptor.invoke(ModelMBeanOperationInterceptor.java:140)
> 	at org.jboss.jmx.connector.invoker.SerializableInterceptor.invoke(SerializableInterceptor.java:74)
> 	at org.jboss.mx.server.Invocation.invoke(Invocation.java:90)
> 	at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
> 	at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
> 	at org.jboss.invocation.jrmp.server.JRMPProxyFactory.invoke(JRMPProxyFactory.java:180)
> 	at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
> 	at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
> 	at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
> 	at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
> 	at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
> 	at org.jboss.invocation.jrmp.server.JRMPInvoker$MBeanServerAction.invoke(JRMPInvoker.java:855)
> 	at org.jboss.invocation.jrmp.server.JRMPInvoker.invoke(JRMPInvoker.java:422)
> 	at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:309)
> 	at sun.rmi.transport.Transport$1.run(Transport.java:168)
> 	at java.security.AccessController.doPrivileged(AccessController.java:279)
> 	at sun.rmi.transport.Transport.serviceCall(Transport.java:164)
> 	at sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:506)
> 	at sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.handleRequest(TCPTransport.java:838)
> 	at sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:912)
> 	at java.lang.Thread.run(Thread.java:810)
> Caused by: org.jboss.deployers.client.spi.IncompleteDeploymentException: Summary of incomplete deployments (SEE PREVIOUS ERRORS FOR DETAILS):
> *** DEPLOYMENTS IN ERROR: Name -> Error
> vfszip:/qa/services/hudson/hudson_workspace/workspace/eap5-as-rhel4-x86-ibm/src/jboss-5.1.0.CR1-src/testsuite/output/lib/aoptest.sar/ -> org.jboss.deployers.spi.DeploymentException: Error deploying: jboss.aop:name=ObservableTester
> DEPLOYMENTS IN ERROR:
>   Deployment "vfszip:/qa/services/hudson/hudson_workspace/workspace/eap5-as-rhel4-x86-ibm/src/jboss-5.1.0.CR1-src/testsuite/output/lib/aoptest.sar/" is in error due to the following reason(s): java.lang.NullPointerException
> 	at org.jboss.deployers.plugins.deployers.DeployersImpl.checkComplete(DeployersImpl.java:993)
> 	at org.jboss.deployers.plugins.deployers.DeployersImpl.checkComplete(DeployersImpl.java:939)
> 	at org.jboss.deployers.plugins.main.MainDeployerImpl.checkComplete(MainDeployerImpl.java:873)
> 	at org.jboss.deployers.plugins.main.MainDeployerImpl.checkComplete(MainDeployerImpl.java:862)
> 	at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:833)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira