[jboss-jira] [JBoss JIRA] Commented: (JGRP-1000) COMPRESS corrupts some messages

[Bela Ban (JIRA)]

    [ https://jira.jboss.org/jira/browse/JGRP-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12474077#action_12474077 ] 

Bela Ban commented on JGRP-1000:
--------------------------------

It sucks that a compressed payload would be *greater* than the uncompressed payload ! Therefore I suggest the following change: 
- Allocate a buffer with the length computed as mentioned above
- If the compressed payload is >= the regular payload, we send the regular payload and don't attach a CompressHeader
- Else we send the compressed payload (with a CompressHeader)

WDYT ?

> COMPRESS corrupts some messages
> -------------------------------
>
>                 Key: JGRP-1000
>                 URL: https://jira.jboss.org/jira/browse/JGRP-1000
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.4.5
>            Reporter: Dennis Reed
>            Assignee: Dennis Reed
>             Fix For: 2.4.7, 2.6.11, 2.8
>
>
> COMPRESS.down() stores the compressed message in a temporary buffer the same size as the original message.
> If the compressed size of a message is larger than the original, then part of the message is lost, with no errors reported.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira