[jboss-jira] [JBoss JIRA] Closed: (JBAS-6568) PersistenceManager should retry all DB operations for a reasonable amount of tries

[Adrian Brock (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBAS-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Brock closed JBAS-6568.
------------------------------

    Resolution: Deferred


Like I said before when the remove retries was added, this retry is in the wrong place.
A proper retry should be around the local jdbc transaction blocks, not individual queries.

i.e. it should let the failed local transaction rollback then do the retry.
This also means it will try to get a new jdbc connection in the event that the previous connection
is broken.

A cleaner solution would be to write a wrapper that can be configured around any
PeristenceManager like the NullPersistenceManager.

If you resubmit the patch implemented either way, I'll test it.

> PersistenceManager should retry all DB operations for a reasonable amount of tries
> ----------------------------------------------------------------------------------
>
>                 Key: JBAS-6568
>                 URL: https://jira.jboss.org/jira/browse/JBAS-6568
>             Project: JBoss Application Server
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: JMS (JBossMQ)
>    Affects Versions: JBossAS-4.2.3.GA
>            Reporter: Rico Neubauer
>            Assignee: Adrian Brock
>         Attachments: PersistenceManager_4_2_3_GA.diff
>
>
> org.jboss.mq.pm.jdbc2.PersistenceManager does contain a simple logic in method remove(MessageReference, Tx) to retry a DB operation and therefore bypass sporadic temporary DB failures.
> This should be extended to the other DB-operations of PersistenceManager.
> Tests using a JDBC-driver throwing randomly arbitrary SQLExceptions showed this resolving most of them and keeping the system in a consistent state.
> Tests without a patched PersistenceManager ran quite fast into a dead end where JMS messages were not being processed anymore until restart of the AS - also see http://www.jboss.org/index.html?module=bb&op=viewtopic&t=151023 for this symptom.
> Proposed patch will get attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira