[jboss-jira] [JBoss JIRA] Commented: (JBMESSAGING-1517) Malformed HTTP POST from Post Office management page in JMX Console

[Howard Gao (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBMESSAGING-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12457412#action_12457412 ] 

Howard Gao commented on JBMESSAGING-1517:
-----------------------------------------

This should be an issue of jmx-console. The jmx-console MBeanInspector page doesn't handle the  org.w3c.dom.Element value correctly.  Special characters should use html codes rather than raw characters. For example the following html code:

 <input type="text" name="DataChannelConfig" value='<config>
            <TCP discard_incompatible_packets='true' down_thread='false' enable_bundling='false' loopback='true' max_bundle_size='64000' max_bundle_timeout='30' recv_buf_size='20000000' send_buf_size='640000' skip_suspected_members='true' sock_conn_timeout='300' start_port='7900' up_thread='false' use_incoming_packet_handler='true' use_outgoing_packet_handler='false' use_send_queues='false'/>
            <MPING ip_ttl='8' mcast_addr='228.6.6.6' mcast_port='45567' num_initial_members='2' num_ping_requests='1' timeout='4000'/>
            <MERGE2 down_thread='false' max_interval='100000' min_interval='20000' up_thread='false'/>
            <FD down_thread='false' max_tries='5' shun='true' timeout='10000' up_thread='false'/>
            <FD_SOCK down_thread='false' up_thread='false'/>
            <VERIFY_SUSPECT down_thread='false' timeout='1500' up_thread='false'/>
            <pbcast.NAKACK discard_delivered_msgs='true' down_thread='false' gc_lag='0' max_xmit_size='60000' retransmit_timeout='300,600,1200,2400,4800' up_thread='false' use_mcast_xmit='false'/>

            <pbcast.STABLE desired_avg_gossip='50000' down_thread='false' max_bytes='400000' stability_delay='1000' up_thread='false'/>
            <pbcast.GMS down_thread='false' join_retry_timeout='2000' join_timeout='3000' print_local_addr='true' shun='false' up_thread='false' view_bundling='true'/>
        </config>' >

should be escaped as :


          <input type="text" name="ControlChannelConfig" value='<config>
            <UDP discard_incompatible_packets=&#39;true&#39; down_thread=&#39;false&#39; enable_bundling=&#39;false&#39; ip_ttl=&#39;8&#39; loopback=&#39;false&#39; max_bundle_size=&#39;64000&#39; max_bundle_timeout=&#39;30&#39; mcast_addr=&#39;228.7.7.7&#39; mcast_port=&#39;45568&#39; mcast_recv_buf_size=&#39;25000000&#39; mcast_send_buf_size=&#39;640000&#39; tos=&#39;8&#39; ucast_recv_buf_size=&#39;20000000&#39; ucast_send_buf_size=&#39;640000&#39; up_thread=&#39;false&#39; use_incoming_packet_handler=&#39;true&#39; use_outgoing_packet_handler=&#39;false&#39;/>
            <PING down_thread=&#39;false&#39; num_initial_members=&#39;3&#39; timeout=&#39;2000&#39; up_thread=&#39;false&#39;/>
            <MERGE2 down_thread=&#39;false&#39; max_interval=&#39;100000&#39; min_interval=&#39;20000&#39; up_thread=&#39;false&#39;/>
            <FD_SOCK down_thread=&#39;false&#39; up_thread=&#39;false&#39;/>
            <FD down_thread=&#39;false&#39; max_tries=&#39;5&#39; shun=&#39;true&#39; timeout=&#39;10000&#39; up_thread=&#39;false&#39;/>
            <VERIFY_SUSPECT down_thread=&#39;false&#39; timeout=&#39;1500&#39; up_thread=&#39;false&#39;/>
            <pbcast.NAKACK discard_delivered_msgs=&#39;true&#39; down_thread=&#39;false&#39; gc_lag=&#39;0&#39; max_xmit_size=&#39;60000&#39; retransmit_timeout=&#39;300,600,1200,2400,4800&#39; up_thread=&#39;false&#39; use_mcast_xmit=&#39;false&#39;/>
            <UNICAST down_thread=&#39;false&#39; timeout=&#39;300,600,1200,2400,3600&#39; up_thread=&#39;false&#39;/>
            <pbcast.STABLE desired_avg_gossip=&#39;50000&#39; down_thread=&#39;false&#39; max_bytes=&#39;400000&#39; stability_delay=&#39;1000&#39; up_thread=&#39;false&#39;/>
            <pbcast.GMS down_thread=&#39;false&#39; flush_timeout=&#39;3000&#39; join_retry_timeout=&#39;2000&#39; join_timeout=&#39;3000&#39; print_local_addr=&#39;true&#39; shun=&#39;false&#39; up_thread=&#39;false&#39; use_flush=&#39;true&#39; view_bundling=&#39;true&#39;/>
            <FRAG2 down_thread=&#39;false&#39; frag_size=&#39;60000&#39; up_thread=&#39;false&#39;/>
            <pbcast.STATE_TRANSFER down_thread=&#39;false&#39; flush_timeout=&#39;3000&#39; up_thread=&#39;false&#39; use_flush=&#39;true&#39;/>
            <pbcast.FLUSH auto_flush_conf=&#39;false&#39; down_thread=&#39;false&#39; timeout=&#39;20000&#39; up_thread=&#39;false&#39;/>
        </config>' >

to be correctly handled by the browser.

I'll file a JMX console jira issue.




> Malformed HTTP POST from Post Office management page in JMX Console
> -------------------------------------------------------------------
>
>                 Key: JBMESSAGING-1517
>                 URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1517
>             Project: JBoss Messaging
>          Issue Type: Bug
>    Affects Versions: 1.4.0.SP3_CP03, 1.4.2.GA.SP1
>         Environment: All
>            Reporter: Paul Kaiser
>            Assignee: Howard Gao
>             Fix For: 1.4.0.SP3.CP08, 1.4.4.GA
>
>
> When trying to submit changes to the configuration of the Messaging Post Office from the JMX Console interface, the improper quoting of configuration strings results in an improper HTTP POST. This prevents the submission of any updates to the component.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira