[jboss-jira] [JBoss JIRA] Commented: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components

[Ian Springer (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12458918#action_12458918 ] 

Ian Springer commented on JBAS-6671:
------------------------------------

Also, there are a bunch of other properties which are marked as mandatory in the CF templates that are not really required:

* name=background-validation, mappedName=null, viewUse=NONE, required=true, value=  SimpleMetaType:java.lang.Boolean:false
* name=blocking-timeout-millis, mappedName=null, viewUse=NONE, required=true, value=  SimpleMetaType:java.lang.Long:30000
* name=idle-timeout-minutes, mappedName=null, viewUse=NONE, required=true, value=  SimpleMetaType:java.lang.Integer:30
* name=isSameRM-override-value, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>
* name=jmx-invoker-name, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>
* name=local-transaction, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>
* name=max-pool-size, mappedName=null, viewUse=NONE, required=true, value=  SimpleMetaType:java.lang.Integer:10
* name=min-pool-size, mappedName=null, viewUse=NONE, required=true, value=  SimpleMetaType:java.lang.Integer:0
* name=no-tx-separate-pools, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>
* name=prefill, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>
* name=statistics-formatter, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>
* name=type-mapping, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>
* name=use-java-context, mappedName=null, viewUse=NONE, required=true, value=  SimpleMetaType:java.lang.Boolean:true
* name=use-strict-min, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>
* name=validate-on-match, mappedName=null, viewUse=NONE, required=true, value=  SimpleMetaType:java.lang.Boolean:true
* name=xa-resource-timeout, mappedName=null, viewUse=NONE, required=true, value=  SimpleMetaType:java.lang.Integer:0
* name=xa-transaction, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=  <<<null>>>

These properties are not required in the ds.xml file and so should not be marked as mandatory in the ManagedComponent's metadata either.

I verified that I'm able to create a new CF via applyTemplate() even when all of the above properties are null or have null values, which further suggests they are optional.


> on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBAS-6671
>                 URL: https://jira.jboss.org/jira/browse/JBAS-6671
>             Project: JBoss Application Server
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: ProfileService
>            Reporter: Ian Springer
>            Assignee: Scott M Stark
>            Priority: Minor
>
> When creating or updating a ConnectionFactory component, when the jndi-name prop is not specified, I get:
> DEPLOYMENTS IN ERROR:
>   Deployment "vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
> when the rar-name prop is not specified, I get:
> Deployment "vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is in error due to the following reason(s): java.lang.IllegalArgumentException: Null name 
> and when the connection-definition prop is not specified, I get:
> Deployment "vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException: ConnectionDefinition 'null' not found in rar 'null' 
> which tells me all three of these props are required, so prop.isMandatory() should return true, but it currently returns false. It should return true for both CF templates and existing CF components.
> Not directly related to management, but all three of the above error messages could also be significantly improved, e.g.:
> The "jndi-name" property was not specified for connection factory "FooBar" - this property is required.
> The "rar-name" property was not specified for connection factory "FooBar" - this property is required.
> The "connection-definition" property was not specified for connection factory "FooBar" - this property is required.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira