[jboss-jira] [JBoss JIRA] Assigned: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components

[Emanuel Muckenhuber (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBAS-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emanuel Muckenhuber reassigned JBAS-6671:
-----------------------------------------

    Assignee: Jesper Pedersen  (was: Emanuel Muckenhuber)


Jesper can you review and validate that the ManagedProperties on the mcf metadata are correct? especially the attribtues 'mandatory=true' and 'includeInTemplate=true'.
Maybe also the default values specified in the DsDataSourceTemplateInfo.

Once you think this is done you can also close the related JIRA task. Thanks!

> on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBAS-6671
>                 URL: https://jira.jboss.org/jira/browse/JBAS-6671
>             Project: JBoss Application Server
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: ProfileService
>            Reporter: Ian Springer
>            Assignee: Jesper Pedersen
>            Priority: Minor
>
> When creating or updating a ConnectionFactory component, when the jndi-name prop is not specified, I get:
> DEPLOYMENTS IN ERROR:
>   Deployment "vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
> when the rar-name prop is not specified, I get:
> Deployment "vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is in error due to the following reason(s): java.lang.IllegalArgumentException: Null name 
> and when the connection-definition prop is not specified, I get:
> Deployment "vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException: ConnectionDefinition 'null' not found in rar 'null' 
> which tells me all three of these props are required, so prop.isMandatory() should return true, but it currently returns false. It should return true for both CF templates and existing CF components.
> Not directly related to management, but all three of the above error messages could also be significantly improved, e.g.:
> The "jndi-name" property was not specified for connection factory "FooBar" - this property is required.
> The "rar-name" property was not specified for connection factory "FooBar" - this property is required.
> The "connection-definition" property was not specified for connection factory "FooBar" - this property is required.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira