[jboss-jira] [JBoss JIRA] Closed: (JBAOP-730) Rewrite CFlow Algorithm

[Flavia Rainone (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBAOP-730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavia Rainone closed JBAOP-730.
--------------------------------

    Resolution: Done


> Rewrite CFlow Algorithm
> -----------------------
>
>                 Key: JBAOP-730
>                 URL: https://jira.jboss.org/jira/browse/JBAOP-730
>             Project: JBoss AOP
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.1.0.GA
>            Reporter: Flavia Rainone
>            Assignee: Flavia Rainone
>             Fix For: 2.1.1.GA
>
>
> Vide TODO at line 193 of PrecedenceSorter:
>    public static ArrayList<PrecedenceDefEntry> mergePrecedenceDef(ArrayList<PrecedenceDefEntry> overall, PrecedenceDef precedenceDef)
>    {
>       //TODO This can be improved. If you have the precedences
>       //		1) A, D
>       //    2) C, E
>       //    3) C, D
>       //After adding 2) to 1) since there is no relationship defined you get:
>       //    i) A, D, C, E
>       //After adding 3) to i) you end up with an overall precedence of
>       //    ii) A, C, D, C, E,
>       //In practice this should be fine, since the applyPrecedence() looks for the
>       //first matching entry, so the second (duplicate) occurrence of C is ignored.
> This algorithm should be replaced by an algorithm that does not generates duplicates entries for the same advice and that recognizes when the dependencies are circular.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira