[jboss-jira] [JBoss JIRA] Commented: (JBBOOT-75) Don't use common lock for start/shutdown

Tue May 26 10:33:56 EDT 2009

    [ https://jira.jboss.org/jira/browse/JBBOOT-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12469163#action_12469163 ] 

David Lloyd commented on JBBOOT-75:
-----------------------------------

Seems ill-advised to me - multiple locks are asking for trouble.  I'd suggest using one lock and taking advantage of interruption to provide an ability to asynchronously abort server startup, like any other service might do.

> Don't use common lock for start/shutdown
> ----------------------------------------
>
>                 Key: JBBOOT-75
>                 URL: https://jira.jboss.org/jira/browse/JBBOOT-75
>             Project: JBoss Bootstrap
>          Issue Type: Feature Request
>          Components: impl-base
>            Reporter: Andrew Lee Rubinger
>            Assignee: Andrew Lee Rubinger
>             Fix For: Unscheduled
>
>
> Both startup and shutdown block on the same "this" reference, meaning that the server may not be shutdown until startup is complete.  Give each its own lock, and ensure that *all* operations mutating the internal state sync on both locks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira