[jboss-jira] [JBoss JIRA] Created: (JBCLUSTER-243) AbstractJBossCacheService.getUnmarshalledValue suppresses problems

Brian Stansberry (JIRA) jira-events at lists.jboss.org
Wed Oct 21 15:56:06 EDT 2009


AbstractJBossCacheService.getUnmarshalledValue suppresses problems
------------------------------------------------------------------

                 Key: JBCLUSTER-243
                 URL: https://jira.jboss.org/jira/browse/JBCLUSTER-243
             Project: JBoss Clustering
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: HA-Server-Cache-JBC
    Affects Versions: HA-Server-Cache-JBC 2.0.1.GA 
            Reporter: Brian Stansberry
            Assignee: Brian Stansberry
             Fix For: HA-Server-Cache-JBC 2.1.0.GA 


Exceptions are being semi-swallowed and nulls returned.
      try
      {
         ...
         
         SimpleCachableMarshalledValue mv = (SimpleCachableMarshalledValue) obj;
         mv.setObjectStreamSource(SessionSerializationFactory.getObjectStreamSource());
         return mv.get();
      }
      catch (IOException e)
      {
         log_.error("IOException occurred unmarshalling value ", e);
         return null;
      }
      catch (ClassNotFoundException e)
      {
         log_.error("ClassNotFoundException occurred unmarshalling value ", e);
         return null;
      }
      finally
      {
         ...
      }
   }

Need to evaluate all usage of this method and find a better error handling mechanism; probably either throw the IOException/CNFE or wrap it and throw it; force the caller to deal with it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jboss-jira mailing list