[jboss-jira] [JBoss JIRA] Updated: (JGRP-1076) Include protocol schema in JGroups site and reference it from default config files

[Sei Syvalta (JIRA)]

     [ https://jira.jboss.org/jira/browse/JGRP-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sei Syvalta updated JGRP-1076:
------------------------------

    Attachment: config-validation.patch


Follow-up patch to current head (which seems to have the first patch already applied). This time tested using a jar created by the maven build, and works nicely.

> Include protocol schema in JGroups site and reference it from default config files
> ----------------------------------------------------------------------------------
>
>                 Key: JGRP-1076
>                 URL: https://jira.jboss.org/jira/browse/JGRP-1076
>             Project: JGroups
>          Issue Type: Feature Request
>    Affects Versions: 2.8
>            Reporter: Sei Syvalta
>            Assignee: Bela Ban
>             Fix For: 2.8
>
>         Attachments: config-validation.patch, config-validation.patch
>
>
> Currently config files use following schemaLocation: "file:schema/JGroups-2.8.xsd". This prevents proper auto-completion and validation in IDE's. Schemas could be hosted at JGroups site so that IDE's could access them from there.
> Included is a patch, which:
> - changes schemaLocation to "http://www.jgroups.org/schema/JGroups-2.8.xsd" (in the patch changed only in one example config)
> - changes XMLConfigurator to match that schemaLocation to schemas included in JGroups jar, so that no network connection is used or needed when starting JGroups
> - adds new constructors to XMLConfigurator to allow enabling validation without using system properties (which are often not possible to be used when using JGroups in web app)
> - fixes resource leak where inputStream is not closed
> Some comments about the patch:
> - Using non-primitive Boolean in validate parameter is bit clumsy
> - System property currently overrides the explicit ctor parameter, I think it would be more logical to be the opposite
> - Strings are not constantified
> - functionality is tested manually, but haven't written any tests for it

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira