[jboss-jira] [JBoss JIRA] Commented: (JBCL-24) Circular and self dependencies

[Thomas Diesler (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBCL-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12484908#action_12484908 ] 

Thomas Diesler commented on JBCL-24:
------------------------------------

The information passed in to 

public interface Capability extends Serializable
{
   /**
    * Whether this capability resolves the requirement
    * 
    * @param module the requirement module
    * @param requirement the requirement
    * @throws IllegalArgumentException for a null requirement
    * @return true when it is resolves the requirement
    */
   boolean resolves(Module module, Requirement requirement);
}

is not sufficient for an OSGiPackageCapability to decide whether it should resolve against the given module. It must also know its own association with a Module.

I extended the interface like this

public interface Capability extends Serializable
{
   /**
    * Whether this capability resolves the requirement
    * 
    * @param capModule the capability module
    * @param reqModule the requirement module
    * @param requirement the requirement
    * @throws IllegalArgumentException for a null requirement
    * @return true when it is resolves the requirement
    */
   boolean resolves(Module capModule, Module reqModule, Requirement requirement);
}

which allows capability/requirement matching in the context of both modules.

> Circular and self dependencies
> ------------------------------
>
>                 Key: JBCL-24
>                 URL: https://jira.jboss.org/jira/browse/JBCL-24
>             Project: JBoss ClassLoader
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Adrian Brock
>            Assignee: Thomas Diesler
>
> Test and add support for circular dependencies.
> This basically involves some of kind of hack to pretend the dependency is resolved
> when we spot the real blockage is a classloader either directly or indirectly depending upon itself
> with all other dependencies in the classloading space resolved.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira