[jboss-jira] [JBoss JIRA] Created: (JBVFS-120) Handler for vfsmemory should override getHostAddress(URL)

[Ales Justin (JIRA)]

Handler for vfsmemory should override getHostAddress(URL)
---------------------------------------------------------

                 Key: JBVFS-120
                 URL: https://jira.jboss.org/jira/browse/JBVFS-120
             Project: JBoss VFS
          Issue Type: Task
      Security Level: Public (Everyone can see)
    Affects Versions: 2.1.2.GA
            Reporter: Ales Justin
            Assignee: Ales Justin
             Fix For: 2.1.3.GA


See JBCL-117.


Isn't the real issue here that
org.jboss.virtual.protocol.vfsmemory.Handler
doesn't override

URLStreamHandler.hashCode(url)

It is using the "host" part of the url for something that is not a host.
This is leading to spurious DNS lookups that cannot be cached because they always fail. 


The attached patch does this by overriding getHostAddress(URL) inside org.jboss.virtual.protocol.vfsmemory.Handler to always return null. This is also semantically correct, since vfsmemory "hosts" are not real hosts at all.

There's no reason to override hashCode() or equals(), as they both use getHostAddress(). 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira