[jboss-jira] [JBoss JIRA] Updated: (JGRP-1064) Serialization untidiness in AuthToken

[Brian Stansberry (JIRA)]

     [ https://jira.jboss.org/jira/browse/JGRP-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry updated JGRP-1064:
-----------------------------------

    Description: 
The abstract AuthToken class implements Serializable, so the AS serialization compatibility tests are monitoring it for incompatible changes. Per JBAS-7265 looks like one has crept in:

FAIL: serialVersionUID error for org.jgroups.auth.AuthToken, 500 3079597723572751028, current: -2876389454499198917 

This is minor, since JGroups presumably uses Streamable to marshal/unmarshal these. But some tidy up would be good:

1) The AuthToken.auth field should be transient since AUTH is not serializable.

2) A serialVersionUid field should be added to AuthToken and all subclasses.


Do these classes need to be Serializable? If not, perhaps remove that in 3.0?



  was:
The abstract AuthToken class implements Serializable, so the AS serialization compatibility tests are monitoring it for incompatible changes. Per JBAS-7265 looks like one has crept in:

FAIL: serialVersionUID error for org.jgroups.auth.AuthToken, 500 3079597723572751028, current: -2876389454499198917 

This is minor, since JGroups presumably uses Streamable to marshal/unmarshal these. But some tidy up would be good:

1) The AuthToken.auth field should be transient since AUTH is not serializable.

2) A serialVersionUid field should be added to AuthToken and all subclasses.  The value for AuthToken should be -2876389454499198917. I'm seeing if I can find out what the value should be for the various subclasses.


Do these classes need to be Serializable? If not, perhaps remove that in 3.0?





Edited description to remove bit about using particular values that the AS serialization compatibility test expects. JGroups has had 2 releases (2.6.11 and 2.6.12) since the calculated serialVersionUID changed, so the new values are out there in the wild. So best is to recognize these values have been changing across releases and just generate a current serialVersionUID for AuthToken and subclasses so it stops jumping around. The changing values are no big deal since java serialization isn't really used for these classes.

Since java serialization isn't used by JGroups for these classes, they are being excluded by the AS serialization compatibility tests.

> Serialization untidiness in AuthToken
> -------------------------------------
>
>                 Key: JGRP-1064
>                 URL: https://jira.jboss.org/jira/browse/JGRP-1064
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.6.12
>            Reporter: Brian Stansberry
>            Assignee: Bela Ban
>            Priority: Minor
>
> The abstract AuthToken class implements Serializable, so the AS serialization compatibility tests are monitoring it for incompatible changes. Per JBAS-7265 looks like one has crept in:
> FAIL: serialVersionUID error for org.jgroups.auth.AuthToken, 500 3079597723572751028, current: -2876389454499198917 
> This is minor, since JGroups presumably uses Streamable to marshal/unmarshal these. But some tidy up would be good:
> 1) The AuthToken.auth field should be transient since AUTH is not serializable.
> 2) A serialVersionUid field should be added to AuthToken and all subclasses.
> Do these classes need to be Serializable? If not, perhaps remove that in 3.0?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira