[jboss-jira] [JBoss JIRA] Commented: (JBAS-7924) smoke-tests build SUCCESS despite FAILURE

[Thomas Diesler (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBAS-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12525294#action_12525294 ] 

Thomas Diesler commented on JBAS-7924:
--------------------------------------

Here is an example in Hudson

http://jbmuc.dyndns.org:8280/hudson/job/jbossas-git-staging/25/console

If you scroll down to the bottom, you'll see

tests-osgi-raw:
    [junit] Running org.jboss.test.osgi.simple.SimpleRuntimeTestCase
    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0.524 sec
    [junit] Test org.jboss.test.osgi.simple.SimpleRuntimeTestCase FAILED
[server:stop] Shutting down server: osgi
[server:stop] shutdownTimeout will be=45
[server:stop] Server stopped.

BUILD SUCCESSFUL
Total time: 10 minutes 38 seconds
+ cd /home/hudson/share/git/pub/scm/jbossas.git
+ git pull git://jbmuc/~tdiesler/pub/scm/jbossas.git +staging:master
>From git://jbmuc/~tdiesler/pub/scm/jbossas
 + 39b4fe9...54f6299 staging    -> master  (forced update)
Warning: fetch updated the current branch head.
Warning: fast-forwarding your working tree from
Warning: commit 39b4fe9a4eba1a16f408225853c337e4cb4ace25.
Already up-to-date.
+ git svn dcommit

Hudson should terminate the job after the test failure and the shell commands after should not be executed. The underlying issue is that the 
testsuite/build.sh command returns success despite test failures (which it also does in your hudson run).

This is not only a hudson issue, but would also be confusing when you work with the testsuite on the command line. After many tests have run I want to rely on the final output (i.e. SUCCESS or FAILURE) and not have to scan the console output for potential FAILURE messages when the final result is SUCCESS.  

> smoke-tests build SUCCESS despite FAILURE
> -----------------------------------------
>
>                 Key: JBAS-7924
>                 URL: https://jira.jboss.org/jira/browse/JBAS-7924
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Test Suite
>            Reporter: Thomas Diesler
>            Assignee: Shelly McGowan
>             Fix For: JBossAS-6.0.0.M3
>
>
> [tdiesler at tdvaio testsuite]$ ./build.sh clean jars smoke-tests
> smoke-tests:
> [server:start] Starting server "all", with command (start timeout is 120 seconds ): 
> [server:start] /usr/java/jdk1.6.0_17/bin/java -cp /home/tdiesler/git/jbossas/build/target/jboss-6.0.0-SNAPSHOT/bin/run.jar:/usr/java/jdk1.6/lib/tools.jar -Xms128m -Xmx512m -XX:MaxPermSize=512m -XX:+HeapDumpOnOutOfMemoryError -XX:-UseGCOverheadLimit -Djava.net.preferIPv4Stack=true -Djava.endorsed.dirs=/home/tdiesler/git/jbossas/build/target/jboss-6.0.0-SNAPSHOT/lib/endorsed -Djgroups.udp.ip_ttl=0 -Djboss.server.log.threshold=DEBUG -Djava.endorsed.dirs=/home/tdiesler/git/jbossas/build/target/jboss-6.0.0-SNAPSHOT/lib/endorsed/ -Dxb.builder.useUnorderedSequence=true org.jboss.Main -c all -b localhost -g DefaultPartition 
> [server:start] Server started.
> ...
> smoke-tests-raw:
>      [echo] 
>      [echo]    junit.timeout:              300000
>      [echo]    jbosstest.iterationcount:   10
>      [echo]    jbosstest.threadcount:      5
>      [echo]    jbosstest.beancount:        5
>      [echo]          
>     [mkdir] Created dir: /home/tdiesler/git/jbossas/testsuite/output/log
> ...
>     [junit] Running org.jboss.test.jmsra.test.RaJMSSessionUnitTestCase
>     [junit] 	javax.ejb.EJBException: javax.jms.JMSException: Could not create a session: Unable to get managed connection for JmsXA)
>     [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 2.423 sec
>     [junit] Test org.jboss.test.jmsra.test.RaJMSSessionUnitTestCase FAILED
> ...
> [server:stop] Shutting down server: all
> [server:stop] log4j:WARN No appenders could be found for logger (org.jnp.interfaces.TimedSocketFactory).
> [server:stop] log4j:WARN Please initialize the log4j system properly.
> [server:stop] shutdownTimeout will be=45
> [server:stop] Server stopped.
> BUILD SUCCESSFUL
> Total time: 6 minutes 3 seconds

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira