[jboss-jira] [JBoss JIRA] Issue Comment Edited: (JGRP-1256) NakReceiverWindow removeMany infinite loop

[Bela Ban (JIRA)]

    [ https://jira.jboss.org/browse/JGRP-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566482#comment-12566482 ] 

Bela Ban edited comment on JGRP-1256 at 12/1/10 8:04 AM:
---------------------------------------------------------

Yes, I agree: iterating from low to highest_received and removing all messages from xmit_table until xmit_table.size() <= max_xmit_buf_size is correct.

However, I'm seriously thinking about removing max_xmit_buf_size altogether (see above)...

long current=low;
                while(max_xmit_buf_size > 0 && xmit_table.size() > max_xmit_buf_size && current <= highest_received) {
                    Message tmp=xmit_table.remove(current);
                    retransmitter.remove(current);
                    if(current > highest_delivered) {
                        highest_delivered=next_to_remove;
                        if(retval == null)
                            retval=new LinkedList<Message>();
                        if(tmp != null)
                            retval.add(tmp);
                    }
                    current++;
                }

      was (Author: bela at jboss.com):
    Yes, I agree: iterating from low to highest_received and removing all messages from xmit_table until xmit_table.size() <= max_xmit_buf_size is correct.

However, I'm seriously thinking about removing max_xmit_buf_size altogether (see above)...

long current=low;
                while(max_xmit_buf_size > 0 && xmit_table.size() > max_xmit_buf_size && current <= highest_received) {
                    xmit_table.remove(current);
                    retransmitter.remove(current);
                    if(current > highest_delivered)
                        highest_delivered=next_to_remove;
                    current++;
                }
  
> NakReceiverWindow removeMany infinite loop
> ------------------------------------------
>
>                 Key: JGRP-1256
>                 URL: https://jira.jboss.org/browse/JGRP-1256
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.8.1
>            Reporter: ronald yang
>            Assignee: Bela Ban
>             Fix For: 2.12
>
>         Attachments: mping.xml, mping.xml
>
>
> it is possible for the NakReceiverWindow to enter an infinite loop if max_xmit_buf_size has been set.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira