[jboss-jira] [JBoss JIRA] Commented: (JBAS-8734) API change in deployment scanner's add cause failed deployments

[Shelly McGowan (JIRA)]

    [ https://issues.jboss.org/browse/JBAS-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570027#comment-12570027 ] 

Shelly McGowan commented on JBAS-8734:
--------------------------------------

>From what I see from the referenced JIRA, there was a change to 
jbosscore/org/jboss/ide/eclipse/as/core/server/internal/ServerListener.java
-                       String asURL = new File(folders2[i]).toURL().toString(); 
+                      String asURL = encode(folders2[i]);

+
+       private String encode(String folder) throws Exception {
+               folder = folder.replace("\\", "/");  //$NON-NLS-1$//$NON-NLS-2$
+               if (! folder.startsWith("/")) { //$NON-NLS-1$
+                       folder = "/" + folder; //$NON-NLS-1$
+               }
+               URI uri = new URI("file", null, folder, null); //$NON-NLS-1$
+               return uri.toASCIIString();
+       }

So uri.toASCIIString() works on AS 5 but not on AS 6?  


> API change in deployment scanner's add cause failed deployments
> ---------------------------------------------------------------
>
>                 Key: JBAS-8734
>                 URL: https://issues.jboss.org/browse/JBAS-8734
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Deployers
>    Affects Versions: 6.0.0.CR1
>            Reporter: Rob Stryker
>            Assignee: Remy Maucherat
>            Priority: Critical
>         Attachments: JBAS_8734.trace
>
>
> When using the deployment scanner mbean to pass in a new URL that the JBossAS should scan for deployments, a path format which worked fine in JBoss 5 and below no longer works. Specifically, passing in a URL such as the one below:
> file:/home/rob/apps/eclipse/workspaces/main_code/runtime%20space%20workspace/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_6.0_Runtime_Server1292215199516/deploy/Dyn888.war/
> When passing this string into the addURL mbean, the following error in the jboss console results:
> 14:52:54,927 INFO  [org.jboss.web.tomcat.service.deployers.TomcatDeployment] deploy, ctxPath=/Dyn888
> 14:52:54,930 ERROR [org.jboss.kernel.plugins.dependency.AbstractKernelController] Error installing to Start: name=jboss.web.deployment:war=/Dyn888 state=Create mode=Manual requiredState=Installed: java.net.URISyntaxException: Illegal character in path at index 56: file:/home/rob/apps/eclipse/workspaces/main_code/runtime space workspace/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss_6.0_Runtime_Server1292215199516/deploy/Dyn888.war/
> 	at java.net.URI$Parser.fail(URI.java:2809) [:1.6.0_14]
> 	at java.net.URI$Parser.checkChars(URI.java:2982) [:1.6.0_14]
> Despite that I pass in a string with clear %20 blocking out the spaces, the deployment scanner does not seem to recognize this and errors. This format of a string has no problem working in AS 5.1 however. 
> This is blocking JBossTools server integration. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira