[jboss-jira] [JBoss JIRA] Commented: (JGRP-1263) org.jgroups.protocols.UDP - failed sending message to null

[Adrian Tarau (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570456#comment-12570456 ] 

Adrian Tarau commented on JGRP-1263:
------------------------------------

Actually is not, it would do the equal only if multicast = false and that meanst dest != null.

 It would be better if "log.error("failed sending message to " + dest + " (" + msg.size() + " bytes): " + e);" will log the exception instead of using just the exception message, at least we will know where it fails. 

> org.jgroups.protocols.UDP - failed sending message to null
> ----------------------------------------------------------
>
>                 Key: JGRP-1263
>                 URL: https://issues.jboss.org/browse/JGRP-1263
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.10
>         Environment: Linux, Java 1.6.18 32bit
>            Reporter: Adrian Tarau
>            Assignee: Bela Ban
>
> This occurs random and affect the notification mechanism built in our application. 
> Looking in TP
> // Don't send if destination is local address. Instead, switch dst and src and send it up the stack.
>         // If multicast message, loopback a copy directly to us (but still multicast). Once we receive this,
>         // we will discard our own multicast message
>         Address dest=msg.getDest();
>         if(dest instanceof PhysicalAddress) {
>             // We can modify the message because it won't get retransmitted. The only time we have a physical address
>             // as dest is when TCPPING sends the initial discovery requests to initial_hosts: this is below UNICAST,
>             // so no retransmission
>             msg.setDest(null);
>         }
>         final boolean multicast=dest == null || dest.isMulticastAddress();
>         if(loopback && (multicast || dest.equals(msg.getSrc()))) {
>               .....
>         }
> you can notice that it will fail if dest == null when doing the equal. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira