[jboss-jira] [JBoss JIRA] Commented: (JBLOGGING-52) Use of system property for proxy generation setting is too inflexible

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/JBLOGGING-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571730#comment-12571730 ] 

David Lloyd commented on JBLOGGING-52:
--------------------------------------

This setting is very definitely not intended for any purpose even approaching production use.  You should instead use the org.jboss.logging:jboss-logging-tools project to process the logger annotations at build time.  The only time you should be using the property is, for example, testing in your IDE where the whole project is not necessarily being compiled before you run it; in this case the property would be set on the command line.  Dynamic generation of proxies will not be used for any purpose beyond this use case.

> Use of system property for proxy generation setting is too inflexible
> ---------------------------------------------------------------------
>
>                 Key: JBLOGGING-52
>                 URL: https://issues.jboss.org/browse/JBLOGGING-52
>             Project: JBoss Logging
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: jboss-logging-spi
>    Affects Versions: 3.0.0.Beta4-jboss-logging
>            Reporter: Dan Allen
>            Assignee: David Lloyd
>             Fix For: 3.0.0.Beta5-jboss-logging
>
>
> JBoss Logging uses a system property to configure whether or not proxies are generated for type-safe loggers. This approach is very inflexible.
> The main issue is that the value of this system property is being cached too aggressively. In CDI extensions, we are forced to use a static code block to set the property so it is assigned early enough that JBoss Logging caches the correct value. However, with multiple extensions loading in a non-deterministic order, we end up having to put this static block in multiple places. [1]
> We need a better way to apply this setting. Perhaps a static method on a configuration API to assign the value before any logging takes place. 
> [1] https://github.com/seam/solder/blob/master/impl/src/main/java/org/jboss/seam/solder/log/LoggerExtension.java
> https://github.com/seam/servlet/blob/master/impl/src/main/java/org/jboss/seam/servlet/ServletExtension.java 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira