[jboss-jira] [JBoss JIRA] Commented: (JBWEB-147) RewriteValve MBean configuration attribute - getter and setter not compatible

Fri Feb 5 10:27:19 EST 2010

    [ https://jira.jboss.org/jira/browse/JBWEB-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12510671#action_12510671 ] 

Remy Maucherat commented on JBWEB-147:
--------------------------------------

I looked into implementing this but the serialization work is not trivial. I'm accepting patches though.

> RewriteValve MBean configuration attribute - getter and setter not compatible
> -----------------------------------------------------------------------------
>
>                 Key: JBWEB-147
>                 URL: https://jira.jboss.org/jira/browse/JBWEB-147
>             Project: JBoss Web
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: JBossWeb-2.1.4.GA
>            Reporter: Kevin Mudrick
>            Assignee: Remy Maucherat
>
> If one hits the "Apply Changes" in the jboss.web / RewriteValve JMX MBean in the JBoss JMX console, with the existing value (from what the console renders), without making any changes whatsoever, you lose your existing rewrite rules.
> Looking at the code, it seems as though the implementation of the setter and getter methods for the configuration property not quite on the same page.  The getter loops over your rules and conditions, calling toString on each - but the toString implementations for org.jboss.web.rewrite.RewriteCond and org.jboss.web.rewrite.RewriteRule ignore things like the flags.  There are FIXMEs that mention this.  The setter expects a properly formatted, newline-delimited complete set of properties as a String.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira