[jboss-jira] [JBoss JIRA] Commented: (JBAS-7437) AOP does not properly implement latest logging SPI

Tue Feb 9 01:48:19 EST 2010

    [ https://jira.jboss.org/jira/browse/JBAS-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12511195#action_12511195 ] 

David Lloyd commented on JBAS-7437:
-----------------------------------

I amend my response - I'd like to see the following changes in jboss-aop before AS 6.0.0.M3:

1) Delete the AOPLogger class - for one thing, it hooks too deeply into the logging SPI.  For another, because of the way it redirects logging, it causes log formatting to report the wrong file names/line numbers for log messages.
2) Delete org.jboss.aop.util.logging.SystemOutLoggerPlugin - in jboss-logging 3.0+, if no logging provider is installed, it will default to JDK logging rather than "null".

Preferably these changes could go in directly after M2 is tagged.  If not, we're going to have a problem when the log framework is updated again.

If the AOP project team still wishes to maintain a log wrapper for whatever reason, we can get in contact to discuss how it should be done using the proper API (it's not too hard).

> AOP does not properly implement latest logging SPI
> --------------------------------------------------
>
>                 Key: JBAS-7437
>                 URL: https://jira.jboss.org/jira/browse/JBAS-7437
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: AOP
>            Reporter: David Lloyd
>            Assignee: Stale Pedersen
>             Fix For: JBossAS-6.0.0.M2
>
>
> AOP can't instantiate the SystemOutLoggerPlugin because it does not implement the 2.2.0 logging SPI.  This can result in errors like this:
> Failed to initalize plugin: org.jboss.aop.util.logging.SystemOutLoggerPlugin at 6719dc16, cause: java.lang.AbstractMethodError
> in certain cases.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira