[jboss-jira] [JBoss JIRA] Commented: (JGRP-1150) NakAckHeader: streamline serialization (remove 'sender' field ?)

[Bela Ban (JIRA)]

    [ https://jira.jboss.org/jira/browse/JGRP-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12516097#action_12516097 ] 

Bela Ban commented on JGRP-1150:
--------------------------------

I decided not to remove the 'sender' field because it is required for retransmissions on behalf of other members. Anyway, this field is only serialized when type=XMIT_REQ.

> NakAckHeader: streamline serialization (remove 'sender' field ?)
> ----------------------------------------------------------------
>
>                 Key: JGRP-1150
>                 URL: https://jira.jboss.org/jira/browse/JGRP-1150
>             Project: JGroups
>          Issue Type: Task
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>             Fix For: 2.10
>
>
> The 'sender' field is only used for retransmissions, but do we ever use it to request a retransmission on behalf of someone else ? If not, we could use msg.getSrc() instead !
> Currently, an address (UUID) uses 18 bytes, so we would save 18 bytes per multicast message ! This is good as long as we don't have canonicalization of addresses yet

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira