[jboss-jira] [JBoss JIRA] Commented: (JBASM-33) Allow execution of server:stop for servers that aren't running

[Brian Stansberry (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBASM-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12506996#action_12506996 ] 

Brian Stansberry commented on JBASM-33:
---------------------------------------

With this fix in, I'm trying to resolve JBAS-7582. When I try to stop jbm-cluster1 and jbm-cluster2 (which isn't running) I get:

[server:stop] Shutting down server: jbm-cluster1
[server:stop] shutdownTimeout will be=45
[server:stop] Server stopped.
[server:stop] The server jbm-cluster2 is not running; it cannot be stopped.
[server:stop] Writing server thread dump to /home/bes/dev/jboss/trunk/build/output/jboss-6.0.0-SNAPSHOT/server/jbm-cluster2/log/threadDump.log
[server:stop] Failed to shutdown server "jbm-cluster2". Destroying the process.
[server:stop] Unable to shutdown server properly: org.jboss.jbossas.servermanager.ServerShutdownException: Failed to shutdown server.Process was destroyed.

I'm concerned about those last 3 lines. Not they are there in the log (no big deal) but that they might indicate something that the overall hudson job will detect, resulting in the message at the end saying that the build failed because some servers failed to shut down cleanly.

> Allow execution of server:stop for servers that aren't running
> --------------------------------------------------------------
>
>                 Key: JBASM-33
>                 URL: https://jira.jboss.org/jira/browse/JBASM-33
>             Project: JBoss AS Server Manager
>          Issue Type: Feature Request
>            Reporter: Brian Stansberry
>            Assignee: Shelly McGowan
>             Fix For: 1.0.3.GA
>
>
> See JBAS-7582 for the use case.
> If you call server:stop passing the name of a server that isn't running, an ISE is thrown, blowing up the overall testsuite run:
> exec-jbmcluster:
>     [junit] Running org.jboss.test.jbossmessaging.clustertest.ClusteredTestCase
>     [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 19.861 sec
> [server:stop] Shutting down server: jbm-cluster1
> [server:stop] shutdownTimeout will be=45
> [server:stop] Server stopped.
> BUILD FAILED
> java.lang.IllegalArgumentException: The jbm-cluster2 is not running; it cannot be stopped.
> 	at org.jboss.jbossas.servermanager.ServerController.stopServer(ServerController.java:377)
> 	at org.jboss.jbossas.servermanager.ServerManager.stopServer(ServerManager.java:174)
> 	at org.jboss.ant.taskdefs.server.StopServerTask.stopServer(StopServerTask.java:74)
> 	at org.jboss.ant.taskdefs.server.StopServerTask.execute(StopServerTask.java:61)
> 	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:288)
> 	at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> 	at org.apache.tools.ant.Task.perform(Task.java:348)
> 	at org.apache.tools.ant.Target.execute(Target.java:357)
> 	at org.apache.tools.ant.Target.performTasks(Target.java:385)
> 	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1337)
> 	at org.apache.tools.ant.Project.executeTarget(Project.java:1306)
> 	at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
> 	at org.apache.tools.ant.Project.executeTargets(Project.java:1189)
> 	at org.apache.tools.ant.Main.runBuild(Main.java:758)
> 	at org.apache.tools.ant.Main.startAnt(Main.java:217)
> 	at org.apache.tools.ant.launch.Launcher.run(Launcher.java:257)
> 	at org.apache.tools.ant.launch.Launcher.main(Launcher.java:104)
> I request that this condition be handled with a log message rather than an ISE.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira