[jboss-jira] [JBoss JIRA] Commented: (JBVFS-161) TempFileProvider should have a injectable FileDelete strategy

[Aslak Knutsen (JIRA)]

    [ https://jira.jboss.org/browse/JBVFS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12538660#action_12538660 ] 

Aslak Knutsen commented on JBVFS-161:
-------------------------------------

(10:39:27 AM) ALR: baileyje: Up yet? :)
(10:39:48 AM) baileyje: Yeah :)
(10:40:11 AM) ALR: baileyje: I'd like to get at a TempDir without a ScheduledExecutorService
(10:40:21 AM) ALR: The service is just used for cleanup operations in close()
(10:40:54 AM) ALR: http://pastebin.com/sBuqcbB2
(10:40:59 AM) baileyje: Yeah.  Cleanup with some retry behavior to prevent locking.
(10:41:05 AM) ALR: Yep.
(10:41:12 AM) ALR: baileyje: Can that be optional?
(10:41:32 AM) ALR: And instead go to some deleteOnExit logic if no SES was provided at construction?
(10:42:41 AM) ALR: baileyje: I've a case where we shouldn't be flushing VirtualFiles to getPhysicalFile anyway
(10:42:56 AM) ALR: So providing a SES is kind unnecessary in the first place.
(10:42:57 AM) baileyje: ALR: hmmm.  What is the issue with the executor?
(10:43:03 AM) ALR: baileyje: I don't have one.
(10:43:12 AM) baileyje: ok.  You just want to avoid it..
(10:43:13 AM) ALR: baileyje: And in AS, most components are not allowed to make one.
(10:43:15 AM) ALR: Yeah.
(10:44:15 AM) ALR: baileyje: I'll be happy to make the patch/fix if we can agree on some alternate logic. 
(10:44:52 AM) baileyje: I will pull dmlloyd in on that.  He was the originator of the TempFileProvider.
(10:45:17 AM) ALR: baileyje: Cool, thanks.  We'll see what he says in a bit.
(10:45:44 AM) baileyje: I think if there is a legitimate reason to have a different cleanup strategy, something could be done.
(10:46:02 AM) ALR: baileyje: Simplification / ease of ue.
(10:46:04 AM) ALR: *use

> TempFileProvider should have a injectable FileDelete strategy
> -------------------------------------------------------------
>
>                 Key: JBVFS-161
>                 URL: https://jira.jboss.org/browse/JBVFS-161
>             Project: JBoss VFS
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>            Reporter: Aslak Knutsen
>            Assignee: John Bailey
>
> TempFileProvider needs a ScheduledExecutorService to clean up created files if it fails the fail the first time(e.g. file locking issues).
> In some cases, e.g. a pure in-memory FileSystem implementation, this is overhead and not needed. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira