[jboss-jira] [JBoss JIRA] Commented: (JBAS-8168) Improve Usability of Error Message During Failed Injection

[Remy Maucherat (JIRA)]

    [ https://jira.jboss.org/browse/JBAS-8168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12538846#action_12538846 ] 

Remy Maucherat commented on JBAS-8168:
--------------------------------------

I think I could catch the exception in populateEnc, log the error for each one with details using the EncInjector, and then throw an exception (if an error actually occurred).

> Improve Usability of Error Message During Failed Injection
> ----------------------------------------------------------
>
>                 Key: JBAS-8168
>                 URL: https://jira.jboss.org/browse/JBAS-8168
>             Project: JBoss Application Server
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Web (Tomcat) service
>    Affects Versions: 6.0.0.M3
>            Reporter: Andrew Lee Rubinger
>            Assignee: Remy Maucherat
>
> Consider the following error trace in JBossAS 6.0.0.M3:
> 14:50:09,467 ERROR [org.jboss.web.tomcat.service.deployers.TomcatDeployment] ENC setup failed: java.lang.IllegalStateException: Resolution should not happen via injection container
> 	at org.jboss.web.tomcat.service.TomcatInjectionContainer.getEjbJndiName(TomcatInjectionContainer.java:683) [:6.0.0.20100429-M3]
> 	at org.jboss.injection.EjbEncInjector.inject(EjbEncInjector.java:80) [:1.3.1]
> 	at org.jboss.web.tomcat.service.TomcatInjectionContainer.populateEnc(TomcatInjectionContainer.java:507) [:6.0.0.20100429-M3]
> 	at org.jboss.web.tomcat.service.deployers.TomcatDeployment$EncListener.lifecycleEvent(TomcatDeployment.java:448) [:6.0.0.20100429-M3]
> 	at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:115) [:6.0.0.20100429-M3]
> 	at org.apache.catalina.core.StandardContext.start(StandardContext.java:4192) [:6.0.0.20100429-M3]
> 	at org.jboss.web.tomcat.service.deployers.TomcatDeployment.performDeployInternal(TomcatDeployment.java:323) [:6.0.0.20100429-M3]
> 	at org.jboss.web.tomcat.service.deployers.TomcatDeployment.performDeploy(TomcatDeployment.java:148) [:6.0.0.20100429-M3]
> 	at org.jboss.web.deployers.AbstractWarDeployment.start(AbstractWarDeployment.java:462) [:6.0.0.20100429-M3]
> 	at org.jboss.web.deployers.WebModule.startModule(WebModule.java:116) [:6.0.0.20100429-M3]
> 	at org.jboss.web.deployers.WebModule.start(WebModule.java:95) [:6.0.0.20100429-M3]
> This occurs when attempting to inject an unknown type.  Recommend a more user-friendly message detailing the type of field requested, as well as its name and class located. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira