[jboss-jira] [JBoss JIRA] Commented: (JBRULES-2593) JPAKnowledgeServiceBean does not initialize JPAKnowledgeFactoryService

[Mark Proctor (JIRA)]

    [ https://jira.jboss.org/browse/JBRULES-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12541099#action_12541099 ] 

Mark Proctor commented on JBRULES-2593:
---------------------------------------

That bean isn't used any more. Spring has undergone a lot of improvements. All interaction with drools should be done via the custom namespace elements, see the release notes for more details
https://hudson.jboss.org/hudson/job/drools/lastSuccessfulBuild/artifact/trunk/target/docs/drools-introduction/html/ch02.html#d4e25

And here are sample xml from unit tests:
http://fisheye.jboss.org/browse/JBossRules/trunk/drools-container/drools-spring/src/test/resources/org/drools/container/spring/beans.xml?r=HEAD
http://fisheye.jboss.org/browse/JBossRules/trunk/drools-container/drools-spring/src/test/resources/org/drools/container/spring/no-node-beans.xml?r=HEAD
http://fisheye.jboss.org/browse/JBossRules/trunk/drools-container/drools-spring/src/test/resources/org/drools/container/spring/kagents-beans.xml?r=HEAD
http://fisheye.jboss.org/browse/JBossRules/trunk/drools-container/drools-spring/src/test/resources/org/drools/container/spring/beans/persistence/beansVarPersistence.xml?r=HEAD
http://fisheye.jboss.org/browse/JBossRules/trunk/drools-container/drools-spring/src/test/resources/org/drools/container/spring/beans/persistence/VariablePersistenceStrategyProcess.rf?r=HEAD
http://fisheye.jboss.org/browse/JBossRules/trunk/drools-container/drools-spring/src/test/resources/org/drools/container/spring/beans/persistence/beans.xml?r=HEAD

> JPAKnowledgeServiceBean does not initialize JPAKnowledgeFactoryService
> ----------------------------------------------------------------------
>
>                 Key: JBRULES-2593
>                 URL: https://jira.jboss.org/browse/JBRULES-2593
>             Project: Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: All
>    Affects Versions: 5.1.0.CR1
>         Environment: N/A
>            Reporter: Anatoly Polinsky
>            Assignee: Mark Proctor
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> private JPAKnowledgeFactoryService                           jpaKnowledgeServiceProvider;
> in "JPAKnowledgeServiceBean" is not initialized. It used to be by:
>     protected void initDao() {
>         ...  ...  ...
>         jpaKnowledgeServiceProvider = node.get( JPAKnowledgeFactoryService.class );
>         if ( jpaKnowledgeServiceProvider instanceof JPAKnowledgeProviderLocalClient ) {
>             JPAKnowledgeProviderLocalClient local = (JPAKnowledgeProviderLocalClient) jpaKnowledgeServiceProvider;
>             local.setCommandServiceClass( SpringSingleSessionCommandService.class );
>         } else {
>             throw new RuntimeDroolsException( "JPAKnowledgeService is not instance of: " + JPAKnowledgeProviderLocalClient.class.getName() );
>         }
>     }
> but now this code is commented out [ in the latest SNAPSHOT as well ]. Therefore both:
>     public StatefulKnowledgeSession newStatefulKnowledgeSession() {}
> and
>     public StatefulKnowledgeSession loadStatefulKnowledgeSession(final int sessionId) {}
> FAIL, since they use jpaKnowledgeServiceProvider to create / load Sessions:
>          return jpaKnowledgeServiceProvider.newStatefulKnowledgeSession..
>          return jpaKnowledgeServiceProvider.loadStatefulKnowledgeSession..
> -------------------------------------------------------------------------------------------------------------------
> I understand "SpringSingleSessionCommandService" was removed, but this is not the reason to document the whole thing as it breaks the code base that depends on it.
> -------------------------------------------------------------------------------------------------------------------
> If "JPAKnowledgeServiceBean" is deprecated, or a different configuration required, please advise. Is it documented?
> Thank you,
> /Anatoly
>  
> Exception to be indexed by Google:
> java.lang.NullPointerException
> 	at org.drools.container.spring.beans.persistence.JPAKnowledgeServiceBean$1$1.doInJpa(JPAKnowledgeServiceBean.java:42)
> 	at org.drools.container.spring.beans.persistence.JPAKnowledgeServiceBean$1$1.doInJpa(JPAKnowledgeServiceBean.java:41)
> 	at org.springframework.orm.jpa.JpaTemplate.execute(JpaTemplate.java:183)
> 	at org.springframework.orm.jpa.JpaTemplate.execute(JpaTemplate.java:146)
> 	at org.drools.container.spring.beans.persistence.JPAKnowledgeServiceBean$1.doInTransaction(JPAKnowledgeServiceBean.java:40)
> 	at org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:130)
> 	at org.drools.container.spring.beans.persistence.JPAKnowledgeServiceBean.newStatefulKnowledgeSession(JPAKnowledgeServiceBean.java:38)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira