[jboss-jira] [JBoss JIRA] Commented: (JBAS-1796) Review project dependencies and create proper abstractions

[David Lloyd (JIRA)]

    [ https://jira.jboss.org/browse/JBAS-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12541471#action_12541471 ] 

David Lloyd commented on JBAS-1796:
-----------------------------------

Easy, things which conflict just don't get merged!

Well, that's disingenuous - the real answer is that the module system forces every import to be explicit so it will be quite clear what you're introducing when a module is added to the project.  The review process will be able to catch most if not all problems of this type, and it will be easier for people to give feedback because problems will be more obvious.

> Review project dependencies and create proper abstractions
> ----------------------------------------------------------
>
>                 Key: JBAS-1796
>                 URL: https://jira.jboss.org/browse/JBAS-1796
>             Project: JBoss Application Server
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: Other
>            Reporter: Adrian Brock
>            Priority: Critical
>             Fix For: 7.0.0.M1
>
>         Attachments: tattletale-jboss-5.1.0.CR1-rev87856.zip
>
>
> I am getting singlularly fed up with people doing their own integrations
> in such a way that every project needs to depend directly on everything
> in thirdparty and every other project.
> Some people need to go on a course to learn the meaning of abstraction.
> e.g.
> The server module is an integration project. It should not be directly dependent
> on implementation details of Xerces:
> package org.jboss.webservice.metadata.wsdl;
> import org.apache.xerces.xs.XSComplexTypeDefinition;
> import org.apache.xerces.xs.XSTypeDefinition;
> import org.jboss.webservice.metadata.wsdl.WSDLConstants;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDComplexType;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDElement;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDSchema;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDSimpleType;
> import org.jboss.webservice.metadata.wsdl.xsd.XSDType;
> import javax.xml.namespace.QName;
> import java.io.File;
> import java.io.FileWriter;
> import java.io.IOException;
> import java.lang.reflect.Field;
> import java.lang.reflect.Method;
> import java.lang.reflect.Modifier;
> import java.net.URL;
> import java.util.ArrayList;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
> import java.util.Map;
> public class WSDLUtils
> {
>    private String newline = System.getProperty("line.separator");

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira