[jboss-jira] [JBoss JIRA] Updated: (JBAS-8063) run.sh script should not employ JAVA_OPTS when testing java vesion for 64 bit support

[Andrew Dinn (JIRA)]

     [ https://jira.jboss.org/browse/JBAS-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Dinn updated JBAS-8063:
------------------------------

    Description: 
run.sh executes

  "$JAVA" -version

at various places. The version in trunk does so at line 184 in order to check whether this is a 64 bit JVM. Unfortunately it actually executes

    "$JAVA" $JAVA_OPTS -version

This works if the caller of run.sh has not set JAVA_OPTS in which case it will  only contain settings added by the run.sh script itself. However, it is no use when JAVA_OPTS contains settings like -javaagent:<agentlib> etc since this can stop the java -version call from exiting.

I do't think there is any need to pass JAVA_OPTS here (none of the other cases where java -version is executed need to do so). If it really is necessary to pass some of the values added by run.sh to java at thsi point then this should be done by accumulating the addde values up to this point without including the values supplied by the caller of run.sh.

Assigning this to Mladen as his fingerprints are on the offending line :-)


  was:
run.sh executes

  "$JAVA" -version

at various places. The version in trunk does so at line 184 in order to check whether this is a 64 bit JVM. Unfortunately it actually executes

    "$JAVA" $JAVA_OPTS -version

This works if the caller of run.sh has not set JAVA_OPTS in which case it will  only contain settings added by the run.sh script itself. However, it is no use when JAVA_OPTS contains settings like -javaagent:<agentlib> etc since this can stop the java -version call from exiting.

I do't think there is any need to set JAVA_OPTS here (none of the other cases where java -version is executed need to do so). If it really is necessary to pass some of the values added by run.sh to java at thsi point then this should be done by accumulating the addde values up to this point without including the values supplied by the caller of run.sh.

Assigning this to Mladen as his fingerprints are on the offending line :-)




> run.sh script should not employ JAVA_OPTS when testing java vesion for 64 bit support
> -------------------------------------------------------------------------------------
>
>                 Key: JBAS-8063
>                 URL: https://jira.jboss.org/browse/JBAS-8063
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Other
>    Affects Versions: 6.0.0.M4
>            Reporter: Andrew Dinn
>            Assignee: Mladen Turk
>             Fix For: 6.0.0.M4
>
>
> run.sh executes
>   "$JAVA" -version
> at various places. The version in trunk does so at line 184 in order to check whether this is a 64 bit JVM. Unfortunately it actually executes
>     "$JAVA" $JAVA_OPTS -version
> This works if the caller of run.sh has not set JAVA_OPTS in which case it will  only contain settings added by the run.sh script itself. However, it is no use when JAVA_OPTS contains settings like -javaagent:<agentlib> etc since this can stop the java -version call from exiting.
> I do't think there is any need to pass JAVA_OPTS here (none of the other cases where java -version is executed need to do so). If it really is necessary to pass some of the values added by run.sh to java at thsi point then this should be done by accumulating the addde values up to this point without including the values supplied by the caller of run.sh.
> Assigning this to Mladen as his fingerprints are on the offending line :-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira