[jboss-jira] [JBoss JIRA] Commented: (JBAS-8076) JBossCustomDeployDUFilter has an overly broad excludes list

[jaikiran pai (JIRA)]

    [ https://jira.jboss.org/browse/JBAS-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12534363#action_12534363 ] 

jaikiran pai commented on JBAS-8076:
------------------------------------

Capturing the mail discussion from jboss-dev mailing list:


Thanks for looking into this Brian.

As for the issue, I think, as already pointed out by Remy, relying on 
deployment file names in itself isn't a good way of filtering out 
deployments. I know it's a good to have feature, but I believe it should 
be more of a "user deployment" feature rather than for deployments that 
are shipped by JBoss AS.  From what I understand, the real fix is to add 
a (empty?) jboss-scanning.xml to such deployments which shouldn't be 
scanned. Or maybe there's a better way based on metadata (version)? I'll 
create a separate JIRA for that, so that we can get rid of these name 
based filtering (atleast for JBoss AS shipped deployments).


> JBossCustomDeployDUFilter has an overly broad excludes list
> -----------------------------------------------------------
>
>                 Key: JBAS-8076
>                 URL: https://jira.jboss.org/browse/JBAS-8076
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Brian Stansberry
>            Assignee: Ales Justin
>            Priority: Blocker
>             Fix For: 6.0.0.M4
>
>
> The changes to the excludes list done as part of JBAS-8060 is overly broad. FileNameVirtualFileFilter works by doing a "contains" check against the set of keys, so the list of keys needs to be pretty exact. It currently include easily matched terms like "cluster", "security" and "hornetq".
> This is the cause of testsuite failures such as http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-testSuite-sun16/747/testReport/org.jboss.test.cluster.defaultcfg.clusteredentity.test/  The tests deploy artifacts that include "cluster" in their names, and the artifacts aren't being scanned for EJB3 annotations.
> This may be the cause of other failures as well; e.g. quite a few seem to be related to messaging or security.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira