[jboss-jira] [JBoss JIRA] Commented: (JBAS-7788) <check-valid-connection-sql> done after a failure maybe?
deanhiller (JIRA)
jira-events at lists.jboss.org
Wed Mar 10 13:41:38 EST 2010
[ https://jira.jboss.org/jira/browse/JBAS-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12519278#action_12519278 ]
deanhiller commented on JBAS-7788:
----------------------------------
ah, I found out c3po has testConnectionOnCheckin by the way. That would would perfectly most likely if jboss had something like that. Currently there is an infinite redirect in seam when using check-valid-connection-sql w/postgres but if you take check-valid-connection-sql out, the infinite redirect goes away...yeah, but then recovery stops working....boooo. The fact, is people have it working in one mode or the other right now and I have talked to many who did not even run the test case until I mentioned it plus finding out the exact test case was a real pain when first looking into it and I think most people give up with not needing that much availability...just not a high priority for most.
oh, I don't need the forums now as we have a hack that works and others have verified that it is broken for them.
There is a forum post where others had the issue we ran into as well though I can't find it right now(maybe that is the one vote I see up there). yes, I have no problem with priotization of tickets...more votes get higher attention of course. vote people vote for me...heh heh. anyways thanks!
thanks
Dean
> <check-valid-connection-sql> done after a failure maybe?
> --------------------------------------------------------
>
> Key: JBAS-7788
> URL: https://jira.jboss.org/jira/browse/JBAS-7788
> Project: JBoss Application Server
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: JCA service
> Affects Versions: JBossAS-5.1.0.GA
> Reporter: deanhiller
> Assignee: Jesper Pedersen
>
> related directly to this bug in seam https://jira.jboss.org/jira/browse/JBSEAM-4528
> I would prefer the <check-valid-connection-sql> be run AFTER any exceptions from the jdbc api rather than before it. This would fix half the bug in the ticket referred to above(at least with postgres' case)....
> ie.
> 1. go get a wrapper connection(not from pool)
> 2. when you make a real jdbc call, go get the real connection from the pool
> 3. if that jdbc call fails with an exception, run the check-valid-connection-sql
> 4. If check-valid-connection-sql fails, go get another connection from pool(or create one) and if fails, move to next
> 5. once all connections are exhausted, throw exception back to framework or whoever called the jdbc call.
> NOTE: This gives the performance benefit on sunny day we are never running the check valid connection sql. It also solves half of the ticket above which tends to break postgres/jboss/seam combination from working. I have to have check valid connection sql or my seam app never recovers from a db outage but having that also causes all normal seam pages that don't need the database to spin the browser into infinite redirect(ie. if I hit login page it comes up in jboss/seam IF AND ONLY IF I don't have check-valid-connection-sql set).
> thanks,
> Dean
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jboss-jira
mailing list