[jboss-jira] [JBoss JIRA] Created: (JBAS-8381) Widen the range of raw SNMP types permitted by RequestHandlerImpl

Kenny MacLeod (JIRA) jira-events at lists.jboss.org
Thu Sep 2 04:38:52 EDT 2010


Widen the range of raw SNMP types permitted by RequestHandlerImpl
-----------------------------------------------------------------

                 Key: JBAS-8381
                 URL: https://jira.jboss.org/browse/JBAS-8381
             Project: JBoss Application Server
          Issue Type: Patch
      Security Level: Public (Everyone can see)
          Components: SNMP adapter
    Affects Versions: JBossAS-5.1.0.GA
            Reporter: Kenny MacLeod
            Assignee: Dimitris Andreadis
            Priority: Minor


RequestHandlerImpl.getValue() for includes logic for determining how to express a JMX attribute in terms of an SNMP type. It supports Long, Integer, and String, as well as values of the raw SnmpTimeTicks and SnmpObjectId types.

I think this should be widened, by removing the check for SnmpTimeTicks and SnmpObjectId, and replacing it with a single check for the SnmpSyntax interface. This would allow beans to return the full range of SNMP types.  Also, an explicit check for null should be performed, and represented by the SnmpNull type.

Note that setValueFor() is already more restrictive than getValueFor(), so we wouldn't be introducing any new asymmetry.

Patch for RequestHandlerImpl.java to follow.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jboss-jira mailing list