[jboss-jira] [JBoss JIRA] Commented: (JBAS-8392) org.jboss.as.javaee.SimpleJavaEEModuleInformer#getModulePath returns incorrect module name for toplevel non-ear deployments
jaikiran pai (JIRA)
jira-events at lists.jboss.org
Tue Sep 7 12:00:52 EDT 2010
[ https://jira.jboss.org/browse/JBAS-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12549461#action_12549461 ]
jaikiran pai commented on JBAS-8392:
------------------------------------
A fix has been committed in AS trunk r108013. smoke-tests pass:
smoke-tests-raw:
[echo]
[echo] junit.timeout: 300000
[echo] jbosstest.iterationcount: 10
[echo] jbosstest.threadcount: 5
[echo] jbosstest.beancount: 5
[echo]
[mkdir] Created dir: /NotBackedUp/jpai/business/jboss/wc/jbossas/trunk/testsuite/output/log
[junit] Running org.jboss.test.aop.test.AOPUnitTestCase
[junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 10.552 sec
[junit] Running org.jboss.test.classloader.test.ScopingUnitTestCase
[junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 6.285 sec
[junit] Running org.jboss.test.cts.test.BmpUnitTestCase
[junit] Tests run: 11, Failures: 0, Errors: 0, Time elapsed: 17.251 sec
[junit] Running org.jboss.test.cts.test.CmpUnitTestCase
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 3.132 sec
[junit] Running org.jboss.test.cts.test.CtsCmp2OptionDUnitTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 17.981 sec
[junit] Running org.jboss.test.cts.test.CtsCmp2UnitTestCase
[junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 3.559 sec
[junit] Running org.jboss.test.cts.test.IndependentJarsUnitTestCase
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 3.758 sec
[junit] Running org.jboss.test.cts.test.MDBUnitTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 6.673 sec
[junit] Running org.jboss.test.cts.test.NestedUserTransactionUnitTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 2.444 sec
[junit] Running org.jboss.test.cts.test.StatelessSessionBrokenCreateUnitTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 2.498 sec
[junit] Running org.jboss.test.cts.test.StatelessSessionUnitTestCase
[junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 28.082 sec
[junit] Running org.jboss.test.ejb3.test.SimpleSessionUnitTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 4.801 sec
[junit] Running org.jboss.test.jbossmessaging.test.JoramUnitTestCase
[junit] Tests run: 197, Failures: 0, Errors: 0, Time elapsed: 29.718 sec
[junit] Running org.jboss.test.jca.test.BaseConnectionManagerUnitTestCase
[junit] Tests run: 11, Failures: 0, Errors: 0, Time elapsed: 29.233 sec
[junit] Running org.jboss.test.jca.test.PoolingUnitTestCase
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1.957 sec
[junit] Running org.jboss.test.jca.test.XADSUnitTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.334 sec
[junit] Running org.jboss.test.jmsra.test.RaJMSSessionUnitTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 2.417 sec
[junit] Running org.jboss.test.jmsra.test.RaQueueUnitTestCase
[junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 5.682 sec
[junit] Running org.jboss.test.jmsra.test.RaSyncRecUnitTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 2.356 sec
[junit] Running org.jboss.test.jmsra.test.RaTopicUnitTestCase
[junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 5.183 sec
[junit] Running org.jboss.test.naming.test.SimpleUnitTestCase
[junit] Tests run: 10, Failures: 0, Errors: 0, Time elapsed: 5.464 sec
[junit] Running org.jboss.test.tm.test.TransactionManagerUnitTestCase
[junit] Tests run: 28, Failures: 0, Errors: 0, Time elapsed: 0.772 sec
[junit] Running org.jboss.test.web.test.WebIntegrationUnitTestCase
[junit] Tests run: 38, Failures: 0, Errors: 0, Time elapsed: 11.454 sec
[junit] Running org.jboss.test.xml.DDValidatorUnitTestCase
[junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 12.658 sec
check.smoke.test.failure:
[server:stop] Shutting down server: all
[server:stop] log4j:WARN No appenders could be found for logger (org.jnp.interfaces.TimedSocketFactory).
[server:stop] log4j:WARN Please initialize the log4j system properly.
[server:stop] shutdownTimeout will be=45
[server:stop] Server stopped.
BUILD SUCCESSFUL
Total time: 4 minutes 39 seconds
> org.jboss.as.javaee.SimpleJavaEEModuleInformer#getModulePath returns incorrect module name for toplevel non-ear deployments
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: JBAS-8392
> URL: https://jira.jboss.org/browse/JBAS-8392
> Project: JBoss Application Server
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: EJB3
> Affects Versions: 6.0.0.M4
> Reporter: jaikiran pai
> Assignee: jaikiran pai
>
> The JavaEEModuleInformer specifies this requirement for getModulePath():
> /**
> * Obtain the relative path of the deployment unit within the JavaEE application
> * or base deployment directory.
> * The deployment unit is either a JavaEE module or a component of the JavaEE module.
> * If the JavaEE module is part of a JavaEE application return the relative
> * path within the JavaEE application otherwise it is considered a stand alone deployment
> * and return the relative path within the base deployment directory.
> * Note that the relative path includes the module name, for example 'lib/bar.jar'.
> *
> * @param deployment the deployment unit of the module or a component
> * @return the relative path of the JavaEE module
> */
> String getModulePath(DeploymentUnit deploymentUnit);
> However the current implementation in SimpleJavaEEModuleInformer has this:
> public String getModulePath(DeploymentUnit unit)
> {
> return unit.getRelativePath();
> }
> This incorrectly returns an empty string for a toplevel non-ear deployment (for ex: a standalone .war deployment).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jboss-jira
mailing list