[jboss-jira] [JBoss JIRA] Created: (JBRULES-2691) Accumulated Code Clean-Up Issues

[Wolfgang Laun (JIRA)]

Accumulated Code Clean-Up Issues
--------------------------------

                 Key: JBRULES-2691
                 URL: https://jira.jboss.org/browse/JBRULES-2691
             Project: Drools
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: All
            Reporter: Wolfgang Laun
            Assignee: Mark Proctor


This issue is meant to be a portmanteau for all relics resulting from refactorings, modifactions, additions and deletions - in short, the flotsam and jetsam of ongoing software maintenance. 

(.) There are two eponymous classes:
   org.drools.base.DefaultConsequenceExceptionHandler
   org.drools.runtime.rule.impl.DefaultConsequenceExceptionHandler
and, thrown from these:
   org.drools.spi.ConsequenceException
   org.drools.runtime.rule.ConsequenceException
Mark: "I believe it's historical,... drools-api has been there long enough that we can start to clean all this up now."

(.) Problem reported with
   ksession.fireAllRules(new RuleNameEndsWithAgendaFilter("test"));
Thomas Swindells: Looks like [...] that there are two agenda filter classes:
   org.drools.runtime.rule.AgendaFilter and
   org.drools.spi.AgendaFilter.
The first one, odrr.AgendaFilter is what is required by the StatefulKnowledgeSession, this then wraps it in a class to convert it to an ods.AgendaFilter which is what the internal classes use. RuleNameEndsWithAgendaFilter seems to implement ods.AgendaFilter and not odrr.AgendaFilter which is what I'd expect - this is possibly a bug.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira