[jboss-jira] [JBoss JIRA] Commented: (JGRP-1232) GossipRouter.stop() call to GossipRouter.clear() is ignored due to GossipRouter.running

[Scott Marlow (JIRA)]

    [ https://jira.jboss.org/browse/JGRP-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12550588#action_12550588 ] 

Scott Marlow commented on JGRP-1232:
------------------------------------

I'll wait for discussion on IRC before committing the change.  

> GossipRouter.stop() call to GossipRouter.clear() is ignored due to GossipRouter.running
> ---------------------------------------------------------------------------------------
>
>                 Key: JGRP-1232
>                 URL: https://jira.jboss.org/browse/JGRP-1232
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.10
>            Reporter: Scott Marlow
>            Assignee: Scott Marlow
>
> Came across this while working on Infinispan integration into AS 6.  One of the AS test cases (integration branch view http://anonsvn.jboss.org/repos/jbossas/branches/infinispan-int/testsuite/src/main/org/jboss/test/cluster/defaultcfg/test/DRMTestCase.java) is starting a gossip router for testing (with two members).  After testing a few things, we stop the gossip router.  We then test to see if the group membership (via AS cluster partition abstraction) has been updated).  It is expected that each AS node will see one member in their view but they still see two (which triggers a failure).
> Anyway, while looking into the above, I noticed that GossipRouter.stop invokes GossipRouter.clear but only after setting GossipRouter.running = false.  GossipRouter.clear will not close the client connections as a result.  Perhaps we should have GossipRouter.stop + GossipRouter.clear both call an internal clear that is unguarded (e.g. let the public methods guard against GossipRouter.running being false).
> As a short term workaround for the above unit test failure, I changed DRMTestCase to call GossipRouter.clear() before GossipRouter.stop().

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira