[jboss-jira] [JBoss JIRA] Created: (JBAS-8425) UrlIntegrationDeployer.undeploy() doesn't remove from classpath

[Stan Silvert (JIRA)]

UrlIntegrationDeployer.undeploy() doesn't remove from classpath
---------------------------------------------------------------

                 Key: JBAS-8425
                 URL: https://jira.jboss.org/browse/JBAS-8425
             Project: JBoss Application Server
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: Deployers
    Affects Versions: 6.0.0.M4
            Reporter: Stan Silvert
            Assignee: Ales Justin


When a deployment has more than one instance of UrlIntegrationDeployer, undeploy() will not behave properly.  The problem is that INTEGRATION_FLAG_KEY is static:

public static final String IS_INTEGRATION_FLAG_KEY = UrlIntegrationDeployer.class.getSimpleName() + "::isIntegrationDeployment";

During undeploy(), the first UrlIntegrationDeployer instance will remove the attachment from the deployment unit.  Then when undeploy() is called on other instances of UrlIntegrationDeployer, it will not find the flag and thus skip removeFromClassPath().

It looks like IS_INTEGRATION_FLAG_KEY should be an instance variable instead of static.  Perhaps something like this would be an acceptable fix?

public final String IS_INTEGRATION_FLAG_KEY = UrlIntegrationDeployer.class.getSimpleName() + "::isIntegrationDeployment" + "::" + hashCode();

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira