[jboss-jira] [JBoss JIRA] Commented: (JGRP-1355) Enhance ExecutionRunner to allow for better extensibility and safe shut down

[William Burns (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622432#comment-12622432 ] 

William Burns commented on JGRP-1355:
-------------------------------------

Also found a minor issue with tracing.  Right now we don't print a message when a local redirect occurs when actually sending the task from the producer to consumer.

Line 642 of Executing.java

            // If local we pass along without serializing
            if (local_addr.equals(owner.getAddress())) {
                handleTaskSubmittedRequest(runnable, local_addr, requestId);
            }

Need to print a message like Line 296 of Executing.java

                    if (local_addr.equals(owner.getAddress())) {
                        if(log.isTraceEnabled())
                            log.trace("[redirect] <--> [" + local_addr + "] "
                                    + type.name() + " [" + value
                                    + (owner.requestId != -1 ? " request id: " + 
                                            owner.requestId : "")
                                    + "]");

> Enhance ExecutionRunner to allow for better extensibility and safe shut down
> ----------------------------------------------------------------------------
>
>                 Key: JGRP-1355
>                 URL: https://issues.jboss.org/browse/JGRP-1355
>             Project: JGroups
>          Issue Type: Enhancement
>    Affects Versions: 2.12.1
>            Reporter: William Burns
>            Assignee: Bela Ban
>             Fix For: 3.0
>
>   Original Estimate: 1 day
>  Remaining Estimate: 1 day
>
> The ExecutionRunner class which is used for running distributed tasks currently doesn't allow for nice extensibility.  This is caused due to no real hook points or callbacks to add additional local functionality if a user desires.  One such functionality may be to automatically rollback or commit a local database transaction after the task is finished.  This would allow for calling code to not have to care about transactional awareness and be more usuable across a target suite.  Also today there is no nice way of shutting down an ExecutionRunner, it is done today purely with interrupts, and if a task is currently running this will receive an interrupt request which could be problematic.  We should have a way so that when an ExecutionRunner is interrupted that it will shutdown only after finishing the current request or immediately if there is no request.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira