[jboss-jira] [JBoss JIRA] (AS7-2954) TS: Mgmt test utils - move JUnit deps to tests.

[Ondrej Zizka (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649258#comment-12649258 ] 

Ondrej Zizka commented on AS7-2954:
-----------------------------------

And when you're on it, you can fix this as well :)

{quote}
NFO] --- maven-checkstyle-plugin:2.5:checkstyle (check-style) @ jboss-as-testsuite-shared ---
[INFO] Starting audit...
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/ModelUtil.java:33: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/ModelUtil.java:39: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:47: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:49: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:51: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:55: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:63: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:65: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:67: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:70: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:73: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:77: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:79: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:88: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:91: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/HttpMgmtProxy.java:94: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIOpResult.java:29: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIOpResult.java:60: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:85: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:89: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:169: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:191: Line has trailing spaces.
/home/ondra/work/AS7/ozizka-as7/testsuite/shared/src/main/java/org/jboss/as/test/integration/management/util/CLIWrapper.java:195: Line has trailing spaces.
Audit done.
{quote}
                
> TS: Mgmt test utils - move JUnit deps to tests.
> -----------------------------------------------
>
>                 Key: AS7-2954
>                 URL: https://issues.jboss.org/browse/AS7-2954
>             Project: Application Server 7
>          Issue Type: Quality Risk
>            Reporter: Ondrej Zizka
>            Assignee: Dominik Pospisil
>
> Calling JUnit's assert*() from a dependency is not a good idea.
> Pls make it return boolean or throw an exception, and handle it in the test sources.
> CLIWrapper.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira