[jboss-jira] [JBoss JIRA] (AS7-2971) Improve tld parsing error message

[Brad Maxwell (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/AS7-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649708#comment-12649708 ] 

Brad Maxwell commented on AS7-2971:
-----------------------------------

I was going to add this to TldParsingDeploymentProcessor, as I was testing JBoss AS 7.1 Beta, but as I was creating the branch, I found you had already removed the catches and now just catch Exception, so I think this will do the same as I was going to do :-)

        } catch (IllegalArgumentException e) {

             throw new DeploymentUnitProcessingException("Failed to parse " + tld, e);

         } 

The exception should now list the file such as this below.  I close this ticket as done:

21:07:23,567 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-3) MSC00001: Failed to start service jboss.deployment.unit."template.war".PARSE: org.jboss.msc.service.StartException in service jboss.deployment.unit."template.war".PARSE: Failed to process phase PARSE of deployment "template.war"
	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:121) [jboss-as-server-7.1.0.Beta1b.jar:]
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1824) [jboss-msc-1.0.1.GA.jar:]
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1759) [jboss-msc-1.0.1.GA.jar:]
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_27]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_27]
	at java.lang.Thread.run(Thread.java:662) [:1.6.0_27]
Caused by: org.jboss.as.server.deployment.DeploymentUnitProcessingException: Failed to parse "/content/template.war/WEB-INF/lib/spring-modules-validation-0.9.jar/META-INF/valang.tld"
	at org.jboss.as.web.deployment.TldParsingDeploymentProcessor.parseTLD(TldParsingDeploymentProcessor.java:130)
	at org.jboss.as.web.deployment.TldParsingDeploymentProcessor.processTlds(TldParsingDeploymentProcessor.java:105)
	at org.jboss.as.web.deployment.TldParsingDeploymentProcessor.deploy(TldParsingDeploymentProcessor.java:81)
	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:115) [jboss-as-server-7.1.0.Beta1b.jar:]
	... 5 more
Caused by: java.lang.IllegalArgumentException: No enum const class org.jboss.metadata.web.spec.BodyContentType.None
	at java.lang.Enum.valueOf(Enum.java:196) [:1.6.0_27]
	at org.jboss.metadata.web.spec.BodyContentType.valueOf(BodyContentType.java:30)
	at org.jboss.metadata.parser.jsp.TagMetaDataParser.parse(TagMetaDataParser.java:117)
	at org.jboss.metadata.parser.jsp.TldMetaDataParser.parse(TldMetaDataParser.java:226)
	at org.jboss.as.web.deployment.TldParsingDeploymentProcessor.parseTLD(TldParsingDeploymentProcessor.java:124)
	... 8 more
                
> Improve tld parsing error message
> ---------------------------------
>
>                 Key: AS7-2971
>                 URL: https://issues.jboss.org/browse/AS7-2971
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: Web
>    Affects Versions: 7.1.0.Beta1
>            Reporter: Brad Maxwell
>            Assignee: Remy Maucherat
>             Fix For: 7.2.0.Alpha1
>
>
> I encountered a parsing error in an TLD it appears, however the error message gives no help as to where the issue might be.
> 21:01:24,773 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-5) MSC00001: Failed to start service jboss.deployment.unit."template.war".PARSE: org.jboss.msc.service.StartException in service jboss.deployment.unit."template.war".PARSE: Failed to process phase PARSE of deployment "template.war"
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:121) [jboss-as-server-7.1.0.Beta1b.jar:]
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1824) [jboss-msc-1.0.1.GA.jar:]
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1759) [jboss-msc-1.0.1.GA.jar:]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_27]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_27]
> 	at java.lang.Thread.run(Thread.java:662) [:1.6.0_27]
> Caused by: java.lang.IllegalArgumentException: No enum const class org.jboss.metadata.web.spec.BodyContentType.None
> 	at java.lang.Enum.valueOf(Enum.java:196) [:1.6.0_27]
> 	at org.jboss.metadata.web.spec.BodyContentType.valueOf(BodyContentType.java:30)
> 	at org.jboss.metadata.parser.jsp.TagMetaDataParser.parse(TagMetaDataParser.java:117)
> 	at org.jboss.metadata.parser.jsp.TldMetaDataParser.parse(TldMetaDataParser.java:226)
> 	at org.jboss.as.web.deployment.TldParsingDeploymentProcessor.parseTLD(TldParsingDeploymentProcessor.java:124)
> 	at org.jboss.as.web.deployment.TldParsingDeploymentProcessor.processTlds(TldParsingDeploymentProcessor.java:105)
> 	at org.jboss.as.web.deployment.TldParsingDeploymentProcessor.deploy(TldParsingDeploymentProcessor.java:81)
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:115) [jboss-as-server-7.1.0.Beta1b.jar:]
> 	... 5 more

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira