[jboss-jira] [JBoss JIRA] (JGRP-1396) Merge NakreceiverWindow and Retransmitter

[Bela Ban (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650946#comment-12650946 ] 

Bela Ban commented on JGRP-1396:
--------------------------------

Advantages:
- We get rid of the RangeBasedRetransmitter, which had a hashmap of seqnos (and ranges), plus the bit set for each range
- Instead of having *one* retransmission task for each range/seqno, we have *one* retransmission task for all missing messages ! E.g. if we have missing messages 1, 4-10, 100, 102-104, then we have 4 retransmission tasks. In the new scheme, we only have 1 retransmission task, retransmitting a bitmap with the missing seqnos ! This means we have 1 retransmission task per member, and not 1 retransmission task per *missing messages for each member* !
--> This also means fewer entries in TimeScheduler
                
> Merge NakreceiverWindow and Retransmitter
> -----------------------------------------
>
>                 Key: JGRP-1396
>                 URL: https://issues.jboss.org/browse/JGRP-1396
>             Project: JGroups
>          Issue Type: Enhancement
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>             Fix For: 3.2
>
>
> Both NakReceiverWindow and Retransmitter use their own data structures to keep a list of messages received (NRW) and seqnos to be retransmitted (Retrasmitter). This is redundant and costly memory-wise.
> I suggest let's merge the 2 classes, or at least let them share the data structure which keeps track of received messages.
> Suggestion II: create a ring buffer with a (changeable) capacity that keeps track of received messages and messages to be retransmitted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira