[jboss-jira] [JBoss JIRA] (AS7-2954) TS: Mgmt test utils - move JUnit deps to tests.

[Ondrej Zizka (Commented) (JIRA)]

    [ https://issues.jboss.org/browse/AS7-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651974#comment-12651974 ] 

Ondrej Zizka commented on AS7-2954:
-----------------------------------

The reasoning is:
1) JUnit would need to be compile-scope dependency which was claimed as undesirable in dev list
2) Potential assert failure creates a stacktrace starting in different module than the test is in, which makes it harder to examine / fix.
                
> TS: Mgmt test utils - move JUnit deps to tests.
> -----------------------------------------------
>
>                 Key: AS7-2954
>                 URL: https://issues.jboss.org/browse/AS7-2954
>             Project: Application Server 7
>          Issue Type: Quality Risk
>            Reporter: Ondrej Zizka
>            Assignee: Ondrej Zizka
>             Fix For: 7.1.0.CR1
>
>
> Calling JUnit's assert*() from a dependency is not a good idea.
> Pls make it return boolean or throw an exception, and handle it in the test sources.
> CLIWrapper.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira