[jboss-jira] [JBoss JIRA] Created: (JBMESSAGING-1870) ClientSocketWrapper constructors have a redundant call to createStreams()

[Ron Sigal (JIRA)]

ClientSocketWrapper constructors have a redundant call to createStreams()
-------------------------------------------------------------------------

                 Key: JBMESSAGING-1870
                 URL: https://issues.jboss.org/browse/JBMESSAGING-1870
             Project: JBoss Messaging
          Issue Type: Bug
    Affects Versions: 1.4.8.GA, 1.4.0.SP3.CP12
            Reporter: Ron Sigal
            Priority: Minor


org.jboss.jms.client.remoting.ClientSocketWrapper is derived from org.jboss.remoting.transport.socket.ClientSocketWrapper.  The constructors of the former look like

   public ClientSocketWrapper(Socket socket) throws IOException
   {
      super(socket);
      createStreams(socket, null);
   }

   public ClientSocketWrapper(Socket socket, Map metadata, Integer timeout) throws Exception
   {
      super(socket, metadata, timeout);
      createStreams(socket, metadata);
   }

and the constructors of the latter look like

   public ClientSocketWrapper(Socket socket) throws IOException
   {
      super(socket);
      createStreams(socket, null);
   }

   public ClientSocketWrapper(Socket socket, Map metadata, Integer timeout) throws Exception
   {
      super(socket, timeout);
      createStreams(socket, metadata);
   }

The calls to createStreams() in the JBossMessaging versions of ClientSocketWrapper is redundant.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira