[jboss-jira] [JBoss JIRA] Resolved: (AS7-957) adding datasource have problem with connection_properties

[Stefano Maestri (JIRA)]

     [ https://issues.jboss.org/browse/AS7-957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefano Maestri resolved AS7-957.
---------------------------------

    Resolution: Done


https://github.com/jbossas/jboss-as/commit/9e8bf88841a1da25e21957e5ac72626bb8d499da

> adding datasource have problem with connection_properties
> ---------------------------------------------------------
>
>                 Key: AS7-957
>                 URL: https://issues.jboss.org/browse/AS7-957
>             Project: Application Server 7
>          Issue Type: Task
>            Reporter: Stefano Maestri
>            Assignee: Stefano Maestri
>
> <aloubyansky> maeste: i ran into an issue in DataSourcesExtension when storing connection props
> <aloubyansky> maeste: first, they are stored twice
> <aloubyansky> maeste: second, i guess, elements must be written after the attributes, otherwise it's gonna fail
> <aloubyansky> maeste: here https://github.com/aloubyansky/jboss-as/commit/ea1c8b022f51228e8884e14e396015c69dd55f81
> <maeste> aloubyansky: connection_property have to be written only if(!isXaDataSource)
> <maeste> aloubyansky: it's the writing above to be commented
> <maeste> aloubyansky: XaDataSource haven't connection_properties

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira