[jboss-jira] [JBoss JIRA] Assigned: (AS7-1001) WSDeploymentActivator uses a Phase priority which isn't listed in org.jboss.as.server.deployment.Phase

[jaikiran pai (JIRA)]

     [ https://issues.jboss.org/browse/AS7-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

jaikiran pai reassigned AS7-1001:
---------------------------------

    Assignee: Richard Opalka


> WSDeploymentActivator uses a Phase priority which isn't listed in org.jboss.as.server.deployment.Phase
> ------------------------------------------------------------------------------------------------------
>
>                 Key: AS7-1001
>                 URL: https://issues.jboss.org/browse/AS7-1001
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: Web Services
>         Environment: AS7 upstream (Jun 12 2011)
>            Reporter: jaikiran pai
>            Assignee: Richard Opalka
>
> WSDeploymentActivator has code like this for registering deployment unit processors:
> {code}
> static void activate(final BootOperationContext updateContext) {
>         int priority = Phase.INSTALL_WAR_METADATA + 10;
> ...
>        
>         updateContext.addDeploymentProcessor(Phase.INSTALL, priority++, new WSTypeDeploymentProcessor());
>         updateContext.addDeploymentProcessor(Phase.INSTALL, priority++, new WSModelDeploymentProcessor());
> ...
>         addDeploymentProcessors(updateContext, priority);
>     }
> {code}
> Notice that the Phase priorities have been localized to this WS code. Localizing the Phase priority to the WS code can lead to issues where some other subsystem or even WS might end up adding a duplicate Phase priority in org.jboss.as.server.deployment.Phase. The org.jboss.as.server.deployment.Phase is supposed to act as a central location where the phase priorities are listed so that such situations can be avoided.
> Moving the phase priorities out of WSDeploymentActivator (and other such classes, if there are any more) is recommended.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira