[jboss-jira] [JBoss JIRA] Created: (JBRULES-2913) SingleSessionCommandService Constructor Eats an Actual / Real Exception on Rollback

[Esteban Aliverti (JIRA)]

SingleSessionCommandService Constructor Eats an Actual / Real Exception on Rollback 
------------------------------------------------------------------------------------

                 Key: JBRULES-2913
                 URL: https://issues.jboss.org/browse/JBRULES-2913
             Project: Drools
          Issue Type: Bug
      Security Level: Public (Everyone can see)
    Affects Versions: 5.1.1.FINAL
            Reporter: Esteban Aliverti
            Assignee: Esteban Aliverti
            Priority: Minor
             Fix For: FUTURE


Scenario: The constructor of SingleSessionCommandService tries to persist the created SessionInfo and fails.
Problem: Because of the failure, SingleSessionCommandService tries to rollback the TX. If the rollback also fail, an exception is thrown with the cause, but the original problem (The failure on SessionInfo persistence) is swallowed. 
The code of the catch section demonstrate this:

        try {
            this.txm.begin();
 
            //this.appScopedEntityManager.joinTransaction();
            registerRollbackSync();

            jpm.getApplicationScopedPersistenceContext().persist( this.sessionInfo );

            this.txm.commit();

        } catch ( Exception t1 ) {
            try {
                this.txm.rollback();
            } catch ( Throwable t2 ) {
                throw new RuntimeException( "Could not commit session or rollback",
                                            t2 );
            }
            throw new RuntimeException( "Could not commit session",
                                        t1 );
        }

If this.txm.rollback() fails, t1 is never logged.

A similar issue was fixed in JBRULES-2656     

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira