[jboss-jira] [JBoss JIRA] Resolved: (JBAS-8929) CLI address parsing is overly restrictive

[Alexey Loubyansky (JIRA)]

     [ https://issues.jboss.org/browse/JBAS-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Loubyansky resolved JBAS-8929.
-------------------------------------

    Fix Version/s: 7.0.0.Beta1
       Resolution: Done


This is fixed.

> CLI address parsing is overly restrictive
> -----------------------------------------
>
>                 Key: JBAS-8929
>                 URL: https://issues.jboss.org/browse/JBAS-8929
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>            Reporter: Brian Stansberry
>            Assignee: Alexey Loubyansky
>             Fix For: 7.0.0.Beta1
>
>
> This should work:
> [~] host=pingguo.local:read-resource
> The node name is not a valid identifier 'pingguo.local' or the format is wrong for prefix 'null'
> The validation in Util.isValidIdentifier() is limiting things to Character.isJavaIdentifierPart(c[i]) || c[i] == '-'
> The org.jboss.as.controller.PathElement class is what validates address elements as we create them from dmr nodes. It uses the following patterns to validate:
>     /**
>      * A valid key contains alphanumerics and underscores, cannot start with a number, and cannot start or end with
>      * {@code -}.
>      */
>     private static final Pattern VALID_KEY_PATTERN = Pattern.compile("[_a-zA-Z](?:[-_a-zA-Z0-9]*[_a-zA-Z0-9])?");
>     private static final Pattern VALID_VALUE_PATTERN = Pattern.compile("\\*|[^*\\p{Space}\\p{Cntrl}]+");
> Since '=', ':', ',' and '(' have special significance in the CLI there will need to be a mechanism to quote or escape those if used in path element values.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira