[jboss-jira] [JBoss JIRA] Resolved: (JBRULES-2928) Open file leak in Drools Compiler

[Mark Proctor (JIRA)]

     [ https://issues.jboss.org/browse/JBRULES-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Proctor resolved JBRULES-2928.
-----------------------------------

    Resolution: Out of Date


Please review the class in head, I think you'll find this is fixed. if not please re-open with the specific line number that is the problem.

> Open file leak in Drools Compiler
> ---------------------------------
>
>                 Key: JBRULES-2928
>                 URL: https://issues.jboss.org/browse/JBRULES-2928
>             Project: Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: drools-compiler
>    Affects Versions: 5.1.0.FINAL
>         Environment: Glassfish 2.1
>            Reporter: Chris Selwyn
>            Assignee: Mark Proctor
>
> I am running Drools (actually JBoss Rules 5.1.0 ) in Glassfish.
> My deployable is an EJB that uses a StatelessKnowledgeSession to run 
> some rules that I get from a KnowledgeAgent that has a Changeset with a 
> .drl in it.
> Therefore, I have placed the drools compiler into the deployable and it 
> all appears to work.
> Glassfish has a clever little mechanism that, when you unload a 
> deployable that had some open streams, it tells you all about it (and 
> kindly closes them).
> Glassfish is reporting that InputStreams are being left open that were 
> opened in the isPackage() method of 
> org.drools.commons.jci.compilers.EclipseJavaCompiler.
> That method has the following code in it:-
>                  final InputStream is = 
> pClassLoader.getResourceAsStream(ClassUtils.convertClassToResourcePath(pClazzName));
>                  if (is != null) {
>                      return false;
>                  }
> So, when "is" is not null (i.e. open), it is forgotten about and not closed.
> Isn't this a potential file handle leak?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira