[jboss-jira] [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589441#comment-12589441 ] 

David Lloyd commented on JBLOGGING-57:
--------------------------------------

Just in case of what?  Functionally it is identical.  The exception in JBLOGGING-47 simply does not arise from this logic.  This logic correctly identifies the JBoss LogManager as being present.  The problem is that it doesn't detect whether the version found is actually compatible.

Generally I don't approve of superstition-oriented programming. :-)

> Logic for selecting a provider is too fragile
> ---------------------------------------------
>
>                 Key: JBLOGGING-57
>                 URL: https://issues.jboss.org/browse/JBLOGGING-57
>             Project: JBoss Logging
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 3.0.0.Beta4-jboss-logging
>            Reporter: Dan Allen
>            Assignee: David Lloyd
>             Fix For: 3.0.0.Beta5-jboss-logging
>
>
> The logic used to select the logging provider is too fragile. It should never throw an exception while selecting a provider, because JDK logging is guaranteed to be available and should be the fallback choice. When JBoss Logging fails to select a provider, it causes deployment to fail, which violates my rule #1 of a logging framework (don't fail a build because of a failure to setup logging).
> The fragile logic is the reason we get JBLOGGING-47.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira