[jboss-jira] [JBoss JIRA] Commented: (JBLOGGING-57) Logic for selecting a provider is too fragile

[Dan Allen (JIRA)]

    [ https://issues.jboss.org/browse/JBLOGGING-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591392#comment-12591392 ] 

Dan Allen commented on JBLOGGING-57:
------------------------------------

> The multiple try blocks here are not a style choice - they exist so that each framework can be detected separately

I meant having an outer try/catch block. Looking again, I see you are catching Throwable (as opposed to a specific exception like ClassNotFoundException), so then the outer block would indeed be redundant. It would only be needed if something could slip through, which it can't.

> This issue is invalid primarily due to the subjective nature of the word "Fragile". If you can't measure it then I can't fix it.

Fair enough.

> Logic for selecting a provider is too fragile
> ---------------------------------------------
>
>                 Key: JBLOGGING-57
>                 URL: https://issues.jboss.org/browse/JBLOGGING-57
>             Project: JBoss Logging
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 3.0.0.Beta4-jboss-logging
>            Reporter: Dan Allen
>            Assignee: David Lloyd
>             Fix For: 3.0.0.Beta5-jboss-logging
>
>
> The logic used to select the logging provider is too fragile. It should never throw an exception while selecting a provider, because JDK logging is guaranteed to be available and should be the fallback choice. When JBoss Logging fails to select a provider, it causes deployment to fail, which violates my rule #1 of a logging framework (don't fail a build because of a failure to setup logging).
> The fragile logic is the reason we get JBLOGGING-47.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira