[jboss-jira] [JBoss JIRA] Commented: (JBAS-9077) Deployment failure leads to a server hang

[Carlo de Wolf (JIRA)]

    [ https://issues.jboss.org/browse/JBAS-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592377#comment-12592377 ] 

Carlo de Wolf commented on JBAS-9077:
-------------------------------------

If I modify ServerControllerImpl as follows the server will report the failure back correctly:
{noformat}
diff --git a/server/src/main/java/org/jboss/as/server/ServerControllerImpl.java b/server/src/main/java/org/jboss/as/server/ServerControllerImpl.java
index 8d9f1fd..2847d87 100644
--- a/server/src/main/java/org/jboss/as/server/ServerControllerImpl.java
+++ b/server/src/main/java/org/jboss/as/server/ServerControllerImpl.java
@@ -463,8 +463,9 @@ class ServerControllerImpl extends BasicModelController implements ServerControl
                 resultHandler.handleFailed(failureMsg);
             } else {
                 //This is the top level compensating op, which is not going to rollback on runtime failure, so we just return success
-                resultHandler.handleResultFragment(ResultHandler.EMPTY_LOCATION, resultsNode);
-                resultHandler.handleResultComplete();
+//                resultHandler.handleResultFragment(ResultHandler.EMPTY_LOCATION, resultsNode);
+//                resultHandler.handleResultComplete();
+                super.handleFailures();
             }
         }
{noformat}

I then get the following exception as expected:
{noformat}
java.lang.Exception: {"Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-2" => "Deployment failed.  Service failures: [org.jboss.msc.service.StartException in service jboss.deployment.unit.\"epc-propagation.jar\".PARSE: Failed to process phase PARSE of deployment \"epc-propagation.jar\"]"}}
{noformat}

Why would ServerControllerImpl not report back a failure, but instead a success?

> Deployment failure leads to a server hang
> -----------------------------------------
>
>                 Key: JBAS-9077
>                 URL: https://issues.jboss.org/browse/JBAS-9077
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>         Environment: JBoss AS7 master
>            Reporter: jaikiran pai
>             Fix For: 7.0.0.Beta2
>
>         Attachments: error-leads-to-hang.txt
>
>
> This might be related to JBAS-9010 (and/or JBAS-9037). Am not sure, so creating a separate JIRA. A deployment failure like this:
> {code}
> 16:12:54,194 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-2) MSC00001: Failed to start service jboss.deployment.unit."ejb3-example.jar".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."ejb3-example.jar".INSTALL: Failed to process phase INSTALL of deployment "ejb3-example.jar"
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:108)
> 	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1344)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_21]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_21]
> 	at java.lang.Thread.run(Thread.java:619) [:1.6.0_21]
> Caused by: java.lang.NullPointerException
> 	at org.jboss.as.ejb3.component.session.SessionBeanComponentConfiguration.addMethodApplicableLockType(SessionBeanComponentConfiguration.java:139)
> 	at org.jboss.as.ejb3.component.session.SessionBeanComponentDescription.prepareLockConfiguration(SessionBeanComponentDescription.java:263)
> 	at org.jboss.as.ejb3.component.session.SessionBeanComponentDescription.prepareComponentConfiguration(SessionBeanComponentDescription.java:236)
> 	at org.jboss.as.ee.component.AbstractComponentDescription.createComponentConfiguration(AbstractComponentDescription.java:366)
> 	at org.jboss.as.ee.component.ComponentInstallProcessor.deploy(ComponentInstallProcessor.java:81)
> 	at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:102)
> 	... 4 more
> {code}
> causes the demo and the smoke-tests to hang. Attached is the thread dump.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira