[jboss-jira] [JBoss JIRA] Commented: (AS7-187) Datasource attribute "enabled" not writable

Brian Stansberry (JIRA) jira-events at lists.jboss.org
Tue May 3 13:58:18 EDT 2011


    [ https://issues.jboss.org/browse/AS7-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599706#comment-12599706 ] 

Brian Stansberry commented on AS7-187:
--------------------------------------

We reached consensus on this on the jboss-dev list thread:

On 04/21/2011 03:23 PM, Brian Stansberry wrote:
> > On 4/21/11 3:01 AM, Heiko Braun wrote:
>> >>
>> >> Both variants are fine. I can also understand the attempt to
>> >> distinguish operation vs attribute use cases.
>> >>
>> >> IMO this reveals one of the weak sports in the detyped API:
>> >> runtime vs. configuration properties of the system.
>> >>
>> >> to further distinguish these two I would suggest the following,
>> >> which may apply to other subsystems as well:
>> >>
>> >> - if changing the configuration impacts the runtime state (i.e. enabled->disabled)
>> >> then make it an operation
>> >> - if it's merely configuration then make it an attribute
>> >>
> > I'm fine with this, but let's clarify what "impacts the runtime state"
> > means. Many configuration changes will impact the runtime state. Instead
> > of "impacts the runtime state" I'd say "results in an MSC service
> > starting or stopping." That's the main case where an action has rippling
> > effects the user might not anticipate
> >

So based on this, the existing "enable/disable" operations are appropriate for this case, and a "write-attribute" handler is not what we want.

> Datasource attribute "enabled" not writable
> -------------------------------------------
>
>                 Key: AS7-187
>                 URL: https://issues.jboss.org/browse/AS7-187
>             Project: Application Server 7
>          Issue Type: Bug
>          Components: JCA
>            Reporter: Heiko Braun
>            Assignee: Stefano Maestri
>             Fix For: 7.0.0.CR1
>
>
> [localhost:9999 /] /profile=default/subsystem=datasources/data-source=myDS:write-attribute(name=enabled, value=false)
> {
>     "outcome" => "failed",
>     "result" => {"domain-failure-description" => "Attribute enabled is not writeable"}
> }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jboss-jira mailing list